* [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers
[not found] <20251223190844.944633-1-benjamin.philip495@gmail.com>
@ 2025-12-23 19:09 ` Benjamin Philip
2025-12-23 19:27 ` Benjamin Philip
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Philip @ 2025-12-23 19:09 UTC (permalink / raw)
To: platform-driver-x86, linux-kernel
Cc: Mark Pearson, Derek J. Clark, Hans de Goede, Ilpo Järvinen,
Benjamin Philip
This commit replaces the uint32_t standard type with preferred u32
kernel type, fixing the following checkpatch check:
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---
drivers/platform/x86/lenovo/think-lmi.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/lenovo/think-lmi.h
b/drivers/platform/x86/lenovo/think-lmi.h
index 017644323d46..6ea4bceafab2 100644
--- a/drivers/platform/x86/lenovo/think-lmi.h
+++ b/drivers/platform/x86/lenovo/think-lmi.h
@@ -58,19 +58,19 @@ struct tlmi_cert_guids {
#define TLMI_PWDCFG_MODE_MULTICERT 3
struct tlmi_pwdcfg_core {
- uint32_t password_mode;
- uint32_t password_state;
- uint32_t min_length;
- uint32_t max_length;
- uint32_t supported_encodings;
- uint32_t supported_keyboard;
+ u32 password_mode;
+ u32 password_state;
+ u32 min_length;
+ u32 max_length;
+ u32 supported_encodings;
+ u32 supported_keyboard;
};
struct tlmi_pwdcfg_ext {
- uint32_t hdd_user_password;
- uint32_t hdd_master_password;
- uint32_t nvme_user_password;
- uint32_t nvme_master_password;
+ u32 hdd_user_password;
+ u32 hdd_master_password;
+ u32 nvme_user_password;
+ u32 nvme_master_password;
};
struct tlmi_pwdcfg {
--
2.52.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers
2025-12-23 19:09 ` [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers Benjamin Philip
@ 2025-12-23 19:27 ` Benjamin Philip
2025-12-23 20:23 ` Mark Pearson
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Philip @ 2025-12-23 19:27 UTC (permalink / raw)
To: platform-driver-x86, linux-kernel
Benjamin Philip <benjamin.philip495@gmail.com> writes:
> This commit replaces the uint32_t standard type with preferred u32
> kernel type, fixing the following checkpatch check:
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
>
> Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
> ---
> drivers/platform/x86/lenovo/think-lmi.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/think-lmi.h b/drivers/platform/x86/lenovo/think-lmi.h
> index 017644323d46..6ea4bceafab2 100644
> --- a/drivers/platform/x86/lenovo/think-lmi.h
> +++ b/drivers/platform/x86/lenovo/think-lmi.h
> @@ -58,19 +58,19 @@ struct tlmi_cert_guids {
> #define TLMI_PWDCFG_MODE_MULTICERT 3
>
> struct tlmi_pwdcfg_core {
> - uint32_t password_mode;
> - uint32_t password_state;
> - uint32_t min_length;
> - uint32_t max_length;
> - uint32_t supported_encodings;
> - uint32_t supported_keyboard;
> + u32 password_mode;
> + u32 password_state;
> + u32 min_length;
> + u32 max_length;
> + u32 supported_encodings;
> + u32 supported_keyboard;
> };
>
> struct tlmi_pwdcfg_ext {
> - uint32_t hdd_user_password;
> - uint32_t hdd_master_password;
> - uint32_t nvme_user_password;
> - uint32_t nvme_master_password;
> + u32 hdd_user_password;
> + u32 hdd_master_password;
> + u32 nvme_user_password;
> + u32 nvme_master_password;
> };
>
> struct tlmi_pwdcfg {
> --
> 2.52.0
I've seemed to have botched the In-Reply-To header for this email
somehow. Please ignore. Sorry!
-- bp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers
2025-12-23 19:27 ` Benjamin Philip
@ 2025-12-23 20:23 ` Mark Pearson
0 siblings, 0 replies; 4+ messages in thread
From: Mark Pearson @ 2025-12-23 20:23 UTC (permalink / raw)
To: Benjamin Philip, platform-driver-x86, linux-kernel
On Tue, Dec 23, 2025, at 2:27 PM, Benjamin Philip wrote:
> Benjamin Philip <benjamin.philip495@gmail.com> writes:
>
>> This commit replaces the uint32_t standard type with preferred u32
>> kernel type, fixing the following checkpatch check:
>>
>> CHECK: Prefer kernel type 'u32' over 'uint32_t'
>>
>> Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
>> ---
>> drivers/platform/x86/lenovo/think-lmi.h | 20 ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/platform/x86/lenovo/think-lmi.h b/drivers/platform/x86/lenovo/think-lmi.h
>> index 017644323d46..6ea4bceafab2 100644
>> --- a/drivers/platform/x86/lenovo/think-lmi.h
>> +++ b/drivers/platform/x86/lenovo/think-lmi.h
>> @@ -58,19 +58,19 @@ struct tlmi_cert_guids {
>> #define TLMI_PWDCFG_MODE_MULTICERT 3
>>
>> struct tlmi_pwdcfg_core {
>> - uint32_t password_mode;
>> - uint32_t password_state;
>> - uint32_t min_length;
>> - uint32_t max_length;
>> - uint32_t supported_encodings;
>> - uint32_t supported_keyboard;
>> + u32 password_mode;
>> + u32 password_state;
>> + u32 min_length;
>> + u32 max_length;
>> + u32 supported_encodings;
>> + u32 supported_keyboard;
>> };
>>
>> struct tlmi_pwdcfg_ext {
>> - uint32_t hdd_user_password;
>> - uint32_t hdd_master_password;
>> - uint32_t nvme_user_password;
>> - uint32_t nvme_master_password;
>> + u32 hdd_user_password;
>> + u32 hdd_master_password;
>> + u32 nvme_user_password;
>> + u32 nvme_master_password;
>> };
>>
>> struct tlmi_pwdcfg {
>> --
>> 2.52.0
>
> I've seemed to have botched the In-Reply-To header for this email
> somehow. Please ignore. Sorry!
>
> -- bp
Looks fine
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers
2025-12-23 19:09 [PATCH 0/5] platform/x86: think-lmi: Clean up code style Benjamin Philip
@ 2025-12-23 19:19 ` Benjamin Philip
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Philip @ 2025-12-23 19:19 UTC (permalink / raw)
To: platform-driver-x86, linux-kernel
Cc: Mark Pearson, Derek J. Clark, Hans de Goede, Ilpo Järvinen,
Benjamin Philip
This commit replaces the uint32_t standard type with preferred u32
kernel type, fixing the following checkpatch check:
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
---
drivers/platform/x86/lenovo/think-lmi.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/lenovo/think-lmi.h
b/drivers/platform/x86/lenovo/think-lmi.h
index 017644323d46..6ea4bceafab2 100644
--- a/drivers/platform/x86/lenovo/think-lmi.h
+++ b/drivers/platform/x86/lenovo/think-lmi.h
@@ -58,19 +58,19 @@ struct tlmi_cert_guids {
#define TLMI_PWDCFG_MODE_MULTICERT 3
struct tlmi_pwdcfg_core {
- uint32_t password_mode;
- uint32_t password_state;
- uint32_t min_length;
- uint32_t max_length;
- uint32_t supported_encodings;
- uint32_t supported_keyboard;
+ u32 password_mode;
+ u32 password_state;
+ u32 min_length;
+ u32 max_length;
+ u32 supported_encodings;
+ u32 supported_keyboard;
};
struct tlmi_pwdcfg_ext {
- uint32_t hdd_user_password;
- uint32_t hdd_master_password;
- uint32_t nvme_user_password;
- uint32_t nvme_master_password;
+ u32 hdd_user_password;
+ u32 hdd_master_password;
+ u32 nvme_user_password;
+ u32 nvme_master_password;
};
struct tlmi_pwdcfg {
--
2.52.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-23 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20251223190844.944633-1-benjamin.philip495@gmail.com>
2025-12-23 19:09 ` [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers Benjamin Philip
2025-12-23 19:27 ` Benjamin Philip
2025-12-23 20:23 ` Mark Pearson
2025-12-23 19:09 [PATCH 0/5] platform/x86: think-lmi: Clean up code style Benjamin Philip
2025-12-23 19:19 ` [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers Benjamin Philip
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®