mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Sakai <msakai@redhat.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: yunbolyu@smu.edu.sg, kexinsun@smail.nju.edu.cn,
	ratnadiraw@smu.edu.sg, xutong.ma@inria.fr,
	dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference
Date: Tue, 6 Jan 2026 17:44:15 -0500	[thread overview]
Message-ID: <13e4593c-c061-40cb-a0e8-78764488ca67@redhat.com> (raw)
In-Reply-To: <20251230152227.97578-1-Julia.Lawall@inria.fr>

On 12/30/25 10:22 AM, Julia Lawall wrote:
> There is no function advance_compression_stage().  But
> advance_data_vio_compression_stage() does iterate through
> the values of the data_vio_compression_stage enum, so it
> seems to be what was intended.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

We must have missed this comment when we were renaming functions a few 
years ago.

Reviewed-by: Matthew Sakai <msakai@redhat.com>

> ---
>   drivers/md/dm-vdo/data-vio.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-vdo/data-vio.h b/drivers/md/dm-vdo/data-vio.h
> index 067b983bb291..58a1ac806885 100644
> --- a/drivers/md/dm-vdo/data-vio.h
> +++ b/drivers/md/dm-vdo/data-vio.h
> @@ -88,8 +88,8 @@ struct zoned_pbn {
>   };
>   
>   /*
> - * Where a data_vio is on the compression path; advance_compression_stage() depends on the order of
> - * this enum.
> + * Where a data_vio is on the compression path; advance_data_vio_compression_stage()
> + * depends on the order of this enum.
>    */
>   enum data_vio_compression_stage {
>   	/* A data_vio which has not yet entered the compression path */
> 


      reply	other threads:[~2026-01-06 22:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30 15:22 Julia Lawall
2026-01-06 22:44 ` Matthew Sakai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13e4593c-c061-40cb-a0e8-78764488ca67@redhat.com \
    --to=msakai@redhat.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=dm-devel@lists.linux.dev \
    --cc=kexinsun@smail.nju.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ratnadiraw@smu.edu.sg \
    --cc=xutong.ma@inria.fr \
    --cc=yunbolyu@smu.edu.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®