* [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference
@ 2025-12-30 15:22 Julia Lawall
2026-01-06 22:44 ` Matthew Sakai
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2025-12-30 15:22 UTC (permalink / raw)
To: Matthew Sakai
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, dm-devel, linux-kernel
There is no function advance_compression_stage(). But
advance_data_vio_compression_stage() does iterate through
the values of the data_vio_compression_stage enum, so it
seems to be what was intended.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/md/dm-vdo/data-vio.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-vdo/data-vio.h b/drivers/md/dm-vdo/data-vio.h
index 067b983bb291..58a1ac806885 100644
--- a/drivers/md/dm-vdo/data-vio.h
+++ b/drivers/md/dm-vdo/data-vio.h
@@ -88,8 +88,8 @@ struct zoned_pbn {
};
/*
- * Where a data_vio is on the compression path; advance_compression_stage() depends on the order of
- * this enum.
+ * Where a data_vio is on the compression path; advance_data_vio_compression_stage()
+ * depends on the order of this enum.
*/
enum data_vio_compression_stage {
/* A data_vio which has not yet entered the compression path */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference
2025-12-30 15:22 [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference Julia Lawall
@ 2026-01-06 22:44 ` Matthew Sakai
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Sakai @ 2026-01-06 22:44 UTC (permalink / raw)
To: Julia Lawall
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, dm-devel, linux-kernel
On 12/30/25 10:22 AM, Julia Lawall wrote:
> There is no function advance_compression_stage(). But
> advance_data_vio_compression_stage() does iterate through
> the values of the data_vio_compression_stage enum, so it
> seems to be what was intended.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
We must have missed this comment when we were renaming functions a few
years ago.
Reviewed-by: Matthew Sakai <msakai@redhat.com>
> ---
> drivers/md/dm-vdo/data-vio.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-vdo/data-vio.h b/drivers/md/dm-vdo/data-vio.h
> index 067b983bb291..58a1ac806885 100644
> --- a/drivers/md/dm-vdo/data-vio.h
> +++ b/drivers/md/dm-vdo/data-vio.h
> @@ -88,8 +88,8 @@ struct zoned_pbn {
> };
>
> /*
> - * Where a data_vio is on the compression path; advance_compression_stage() depends on the order of
> - * this enum.
> + * Where a data_vio is on the compression path; advance_data_vio_compression_stage()
> + * depends on the order of this enum.
> */
> enum data_vio_compression_stage {
> /* A data_vio which has not yet entered the compression path */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-06 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-30 15:22 [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference Julia Lawall
2026-01-06 22:44 ` Matthew Sakai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®