* [PATCH 1/1] kernel/trace/trace.c: remove unnecessary null test before debugfs_remove
@ 2014-06-26 17:14 Fabian Frederick
2014-06-26 17:44 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-26 17:14 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Steven Rostedt, Frederic Weisbecker
This fixes checkpatch warning:
"WARNING: debugfs_remove(NULL) is safe this check is probably not required"
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
kernel/trace/trace.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 384ede3..58c78e4 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -6095,10 +6095,8 @@ destroy_trace_option_files(struct trace_option_dentry *topts)
if (!topts)
return;
- for (cnt = 0; topts[cnt].opt; cnt++) {
- if (topts[cnt].entry)
- debugfs_remove(topts[cnt].entry);
- }
+ for (cnt = 0; topts[cnt].opt; cnt++)
+ debugfs_remove(topts[cnt].entry);
kfree(topts);
}
--
1.8.4.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] kernel/trace/trace.c: remove unnecessary null test before debugfs_remove
2014-06-26 17:14 [PATCH 1/1] kernel/trace/trace.c: remove unnecessary null test before debugfs_remove Fabian Frederick
@ 2014-06-26 17:44 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2014-06-26 17:44 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Frederic Weisbecker
On Thu, 26 Jun 2014 19:14:31 +0200
Fabian Frederick <fabf@skynet.be> wrote:
> This fixes checkpatch warning:
>
> "WARNING: debugfs_remove(NULL) is safe this check is probably not required"
Thanks, applied to my 3.17 queue.
-- Steve
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> kernel/trace/trace.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 384ede3..58c78e4 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -6095,10 +6095,8 @@ destroy_trace_option_files(struct trace_option_dentry *topts)
> if (!topts)
> return;
>
> - for (cnt = 0; topts[cnt].opt; cnt++) {
> - if (topts[cnt].entry)
> - debugfs_remove(topts[cnt].entry);
> - }
> + for (cnt = 0; topts[cnt].opt; cnt++)
> + debugfs_remove(topts[cnt].entry);
>
> kfree(topts);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-26 17:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-26 17:14 [PATCH 1/1] kernel/trace/trace.c: remove unnecessary null test before debugfs_remove Fabian Frederick
2014-06-26 17:44 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®