[PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[Nicholas Krause]

Removes a FIXME comment in this file due to it not compiling
as it now compiles.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 arch/m68k/include/asm/sun3_pgalloc.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h
index f868506..1798f25 100644
--- a/arch/m68k/include/asm/sun3_pgalloc.h
+++ b/arch/m68k/include/asm/sun3_pgalloc.h
@@ -12,7 +12,6 @@
 
 #include <asm/tlb.h>
 
-/* FIXME - when we get this compiling */
 /* erm, now that it's compiling, what do we do with it? */
 #define _KERNPG_TABLE 0
 
-- 
1.9.1

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[Sam Creasey]

Acked-by: Sam Creasey <sammy@sammy.net>   

On Wed, Jul 02, 2014 at 09:41:33PM -0400, Nicholas Krause wrote:
> Removes a FIXME comment in this file due to it not compiling
> as it now compiles.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/m68k/include/asm/sun3_pgalloc.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h
> index f868506..1798f25 100644
> --- a/arch/m68k/include/asm/sun3_pgalloc.h
> +++ b/arch/m68k/include/asm/sun3_pgalloc.h
> @@ -12,7 +12,6 @@
>  
>  #include <asm/tlb.h>
>  
> -/* FIXME - when we get this compiling */
>  /* erm, now that it's compiling, what do we do with it? */
>  #define _KERNPG_TABLE 0
>  

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[Finn Thain]

On Wed, 2 Jul 2014, Nicholas Krause wrote:

> Removes a FIXME comment in this file due to it not compiling as it now 
> compiles.

What got fixed?

It doesn't say "FIXME - this doesn't compile".

> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/m68k/include/asm/sun3_pgalloc.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h
> index f868506..1798f25 100644
> --- a/arch/m68k/include/asm/sun3_pgalloc.h
> +++ b/arch/m68k/include/asm/sun3_pgalloc.h
> @@ -12,7 +12,6 @@
>  
>  #include <asm/tlb.h>
>  
> -/* FIXME - when we get this compiling */
>  /* erm, now that it's compiling, what do we do with it? */
>  #define _KERNPG_TABLE 0
>  
> 

-- 

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[Nick Krause]

-/* FIXME - when we get this compiling */
>  /* erm, now that it's compiling, what do we do with it? */
What are these two lines for them another compile issue?
Cheers Nick

On Thu, Jul 3, 2014 at 9:28 PM, Finn Thain <fthain@telegraphics.com.au> wrote:
>
> On Wed, 2 Jul 2014, Nicholas Krause wrote:
>
>> Removes a FIXME comment in this file due to it not compiling as it now
>> compiles.
>
> What got fixed?
>
> It doesn't say "FIXME - this doesn't compile".
>
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  arch/m68k/include/asm/sun3_pgalloc.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h
>> index f868506..1798f25 100644
>> --- a/arch/m68k/include/asm/sun3_pgalloc.h
>> +++ b/arch/m68k/include/asm/sun3_pgalloc.h
>> @@ -12,7 +12,6 @@
>>
>>  #include <asm/tlb.h>
>>
>> -/* FIXME - when we get this compiling */
>>  /* erm, now that it's compiling, what do we do with it? */
>>  #define _KERNPG_TABLE 0
>>
>>
>
> --

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[Finn Thain]

On Fri, 4 Jul 2014, Nick Krause wrote:

> What are these two lines for them another compile issue?

I don't see why those two lines are important.

> >> -/* FIXME - when we get this compiling */
> >>  /* erm, now that it's compiling, what do we do with it? */
> >>  #define _KERNPG_TABLE 0

Presumably it is the third line that the "FIXME" refers to.

I didn't write this code, but obviously it isn't supposed to be read as 

/* FIXME - this comment needs to be deleted */

-- 

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[Nick Krause]

Very well then seems I should resend this patch removing the define
line as it seems to have no use
in this file.
Cheers Nick

On Fri, Jul 4, 2014 at 2:19 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
>
> On Fri, 4 Jul 2014, Nick Krause wrote:
>
>> What are these two lines for them another compile issue?
>
> I don't see why those two lines are important.
>
>> >> -/* FIXME - when we get this compiling */
>> >>  /* erm, now that it's compiling, what do we do with it? */
>> >>  #define _KERNPG_TABLE 0
>
> Presumably it is the third line that the "FIXME" refers to.
>
> I didn't write this code, but obviously it isn't supposed to be read as
>
> /* FIXME - this comment needs to be deleted */
>
> --

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

[Geert Uytterhoeven]

On Fri, Jul 4, 2014 at 6:10 PM, Nick Krause <xerofoify@gmail.com> wrote:
> Very well then seems I should resend this patch removing the define
> line as it seems to have no use
> in this file.

Indeed. Thanks in advance!
FYI, the last user of _KERNPG_TABLE was removed in 2.5.18.

> Cheers Nick
>
> On Fri, Jul 4, 2014 at 2:19 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
>>
>> On Fri, 4 Jul 2014, Nick Krause wrote:
>>
>>> What are these two lines for them another compile issue?
>>
>> I don't see why those two lines are important.
>>
>>> >> -/* FIXME - when we get this compiling */
>>> >>  /* erm, now that it's compiling, what do we do with it? */
>>> >>  #define _KERNPG_TABLE 0
>>
>> Presumably it is the third line that the "FIXME" refers to.
>>
>> I didn't write this code, but obviously it isn't supposed to be read as
>>
>> /* FIXME - this comment needs to be deleted */

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds