From: Andrei Warkentin <awarkentin@vmware.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
opensuse-kernel@opensuse.org,
Sergiu Iordache <sergiu@chromium.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
Eddie Wai <eddie.wai@broadcom.com>,
Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Andrei Warkentin <andreiw@vmware.com>
Subject: Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
Date: Fri, 18 Nov 2011 10:46:31 -0800 (PST) [thread overview]
Message-ID: <1406726419.275227.1321641991149.JavaMail.root@zimbra-prod-mbox-2.vmware.com> (raw)
In-Reply-To: <20111117150549.15528e81.akpm@linux-foundation.org>
Hi,
----- Original Message -----
> From: "Andrew Morton" <akpm@linux-foundation.org>
> To: "Andrei Warkentin" <andreiw@vmware.com>
> Cc: linux-kernel@vger.kernel.org, "Rolf Eike Beer" <eike-kernel@sf-tec.de>, opensuse-kernel@opensuse.org, "Sergiu
> Iordache" <sergiu@chromium.org>, "Marco Stornelli" <marco.stornelli@gmail.com>, "Eddie Wai"
> <eddie.wai@broadcom.com>, "Jayamohan Kallickal" <jayamohan.kallickal@emulex.com>, "Guennadi Liakhovetski"
> <g.liakhovetski@gmx.de>
> Sent: Thursday, November 17, 2011 6:05:49 PM
> Subject: Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
>
>
> I assume that nobody has gone off and checked whether all current
> callers will survive this change. If they had, they'd have looked in
> drivers/char/ramoops.c and seen:
>
> rounddown_pow_of_two(pdata->mem_size);
> rounddown_pow_of_two(pdata->record_size);
>
> These operations are no-ops. It should be
>
> pdata->mem_size = rounddown_pow_of_two(pdata->mem_size);
> pdata->record_size = rounddown_pow_of_two(pdata->record_size);
>
> Marco or Sergio: please fix, test and send it over sometime?
I did quickly look through for code that expected rounddown_pow_of_two(1) to give 0,
but I didn't apparently look close enough for other issues.
A
next prev parent reply other threads:[~2011-11-18 18:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 19:56 Andrei Warkentin
2011-11-16 22:51 ` Rolf Eike Beer
2011-11-17 23:05 ` Andrew Morton
2011-11-17 23:19 ` [opensuse-kernel] " Cristian Rodríguez
2011-11-17 23:32 ` Andrew Morton
2011-11-18 18:46 ` Andrei Warkentin [this message]
2011-11-19 9:26 ` Marco Stornelli
2011-11-22 23:34 ` Guennadi Liakhovetski
-- strict thread matches above, loose matches on Subject: below --
2011-12-12 18:02 Dmitry Torokhov
2011-12-12 23:50 ` Linus Torvalds
2011-12-13 6:01 ` Dmitry Torokhov
2011-12-13 20:00 ` Peter Zijlstra
2011-12-13 20:05 ` Peter Zijlstra
2011-11-08 19:08 Andrei Warkentin
2011-11-08 19:57 ` Jesper Juhl
2011-11-14 21:17 ` Andrei Warkentin
2011-11-14 23:27 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406726419.275227.1321641991149.JavaMail.root@zimbra-prod-mbox-2.vmware.com \
--to=awarkentin@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=andreiw@vmware.com \
--cc=eddie.wai@broadcom.com \
--cc=eike-kernel@sf-tec.de \
--cc=g.liakhovetski@gmx.de \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=opensuse-kernel@opensuse.org \
--cc=sergiu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®