From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Andrei Warkentin <andreiw@vmware.com>
Cc: linux-kernel@vger.kernel.org, opensuse-kernel@opensuse.org
Subject: Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
Date: Wed, 16 Nov 2011 23:51:01 +0100 [thread overview]
Message-ID: <1472546.S58to4y67R@donald.sf-tec.de> (raw)
In-Reply-To: <1321473366-31053-1-git-send-email-andreiw@vmware.com>
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
Andrei Warkentin wrote:
> 1 is a power of two, therefore rounddown_pow_of_two(1) should return 1. It
> does in case the argument is a variable but in case it's a constant it
> behaves wrong and returns 0. Probably nobody ever did it so this was never
> noticed, however net/drivers/vmxnet3 with latest GCC does and breaks on
> unicpu systems.
Obviously correct.
Reviewed-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-11-16 22:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 19:56 Andrei Warkentin
2011-11-16 22:51 ` Rolf Eike Beer [this message]
2011-11-17 23:05 ` Andrew Morton
2011-11-17 23:19 ` [opensuse-kernel] " Cristian Rodríguez
2011-11-17 23:32 ` Andrew Morton
2011-11-18 18:46 ` Andrei Warkentin
2011-11-19 9:26 ` Marco Stornelli
2011-11-22 23:34 ` Guennadi Liakhovetski
-- strict thread matches above, loose matches on Subject: below --
2011-12-12 18:02 Dmitry Torokhov
2011-12-12 23:50 ` Linus Torvalds
2011-12-13 6:01 ` Dmitry Torokhov
2011-12-13 20:00 ` Peter Zijlstra
2011-12-13 20:05 ` Peter Zijlstra
2011-11-08 19:08 Andrei Warkentin
2011-11-08 19:57 ` Jesper Juhl
2011-11-14 21:17 ` Andrei Warkentin
2011-11-14 23:27 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472546.S58to4y67R@donald.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=andreiw@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=opensuse-kernel@opensuse.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome