From: "Cristian Rodríguez" <crrodriguez@opensuse.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrei Warkentin <andreiw@vmware.com>,
linux-kernel@vger.kernel.org,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
opensuse-kernel@opensuse.org,
Sergiu Iordache <sergiu@chromium.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
Eddie Wai <eddie.wai@broadcom.com>,
Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [opensuse-kernel] Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
Date: Thu, 17 Nov 2011 20:19:06 -0300 [thread overview]
Message-ID: <4EC5966A.4000106@opensuse.org> (raw)
In-Reply-To: <20111117150549.15528e81.akpm@linux-foundation.org>
On 17/11/11 20:05, Andrew Morton wrote:
> I assume that nobody has gone off and checked whether all current
> callers will survive this change. If they had, they'd have looked in
> drivers/char/ramoops.c and seen:
>
> rounddown_pow_of_two(pdata->mem_size);
> rounddown_pow_of_two(pdata->record_size);
>
> These operations are no-ops. It should be
>
> pdata->mem_size = rounddown_pow_of_two(pdata->mem_size);
> pdata->record_size = rounddown_pow_of_two(pdata->record_size);
>
> That we have this many warts using these interfaces is an indication
> that the interfaces aren't very good. Poorly documented, at least.
>
making that macro an inline function and annotating with
__attribute__((warn_unused_result)) looks like a good start for me.
next prev parent reply other threads:[~2011-11-17 23:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 19:56 Andrei Warkentin
2011-11-16 22:51 ` Rolf Eike Beer
2011-11-17 23:05 ` Andrew Morton
2011-11-17 23:19 ` Cristian Rodríguez [this message]
2011-11-17 23:32 ` [opensuse-kernel] " Andrew Morton
2011-11-18 18:46 ` Andrei Warkentin
2011-11-19 9:26 ` Marco Stornelli
2011-11-22 23:34 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC5966A.4000106@opensuse.org \
--to=crrodriguez@opensuse.org \
--cc=akpm@linux-foundation.org \
--cc=andreiw@vmware.com \
--cc=eddie.wai@broadcom.com \
--cc=eike-kernel@sf-tec.de \
--cc=g.liakhovetski@gmx.de \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=opensuse-kernel@opensuse.org \
--cc=sergiu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome