* [PATCH] trace-cmd: link trace-record in ctracecmd.so
@ 2014-08-15 15:31 Javi Merino
2014-08-22 21:05 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Javi Merino @ 2014-08-15 15:31 UTC (permalink / raw)
To: linux-kernel, Steven Rostedt; +Cc: Javi Merino
Commit b1e9220819eb (trace-cmd: Report stats for all instances) moved
tracecmd_stat_cpu() from trace-recorder.c to trace-record.c. This
makes import ctracecmd fail in tracecmd.py:
$ python tracecmd.py
Traceback (most recent call last):
File "tracecmd.py", line 22, in <module>
from ctracecmd import *
ImportError: ctracecmd.so: undefined symbol: tracecmd_stat_cpu
Link trace-record in ctracecmd.so to add back the required symbol.
Signed-off-by: Javi Merino <javi.merino@arm.com>
---
Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index cbe0eb9..308d7f8 100644
--- a/Makefile
+++ b/Makefile
@@ -317,8 +317,9 @@ KERNEL_SHARK_OBJS = $(TRACE_VIEW_OBJS) $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS) \
PEVENT_LIB_OBJS = event-parse.o trace-seq.o parse-filter.o parse-utils.o
TCMD_LIB_OBJS = $(PEVENT_LIB_OBJS) trace-util.o trace-input.o trace-ftrace.o \
- trace-output.o trace-recorder.o trace-restore.o trace-usage.o \
- trace-blk-hack.o kbuffer-parse.o event-plugin.o
+ trace-output.o trace-record.o trace-recorder.o \
+ trace-restore.o trace-usage.o trace-blk-hack.o \
+ kbuffer-parse.o event-plugin.o
PLUGIN_OBJS =
PLUGIN_OBJS += plugin_jbd2.o
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] trace-cmd: link trace-record in ctracecmd.so
2014-08-15 15:31 [PATCH] trace-cmd: link trace-record in ctracecmd.so Javi Merino
@ 2014-08-22 21:05 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2014-08-22 21:05 UTC (permalink / raw)
To: Javi Merino; +Cc: linux-kernel
On Fri, 15 Aug 2014 16:31:38 +0100
"Javi Merino" <javi.merino@arm.com> wrote:
> Commit b1e9220819eb (trace-cmd: Report stats for all instances) moved
> tracecmd_stat_cpu() from trace-recorder.c to trace-record.c. This
> makes import ctracecmd fail in tracecmd.py:
>
> $ python tracecmd.py
> Traceback (most recent call last):
> File "tracecmd.py", line 22, in <module>
> from ctracecmd import *
> ImportError: ctracecmd.so: undefined symbol: tracecmd_stat_cpu
>
> Link trace-record in ctracecmd.so to add back the required symbol.
>
I just applied this. May push this out next week. I have other changes
I'm adding and need to get them finished before I push it out. It may
not go out until September though.
-- Steve
> Signed-off-by: Javi Merino <javi.merino@arm.com>
> ---
> Makefile | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index cbe0eb9..308d7f8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -317,8 +317,9 @@ KERNEL_SHARK_OBJS = $(TRACE_VIEW_OBJS) $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS) \
>
> PEVENT_LIB_OBJS = event-parse.o trace-seq.o parse-filter.o parse-utils.o
> TCMD_LIB_OBJS = $(PEVENT_LIB_OBJS) trace-util.o trace-input.o trace-ftrace.o \
> - trace-output.o trace-recorder.o trace-restore.o trace-usage.o \
> - trace-blk-hack.o kbuffer-parse.o event-plugin.o
> + trace-output.o trace-record.o trace-recorder.o \
> + trace-restore.o trace-usage.o trace-blk-hack.o \
> + kbuffer-parse.o event-plugin.o
>
> PLUGIN_OBJS =
> PLUGIN_OBJS += plugin_jbd2.o
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-22 21:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-15 15:31 [PATCH] trace-cmd: link trace-record in ctracecmd.so Javi Merino
2014-08-22 21:05 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®