* [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove
@ 2014-08-19 11:57 Mika Westerberg
2014-08-19 14:59 ` Guenter Roeck
2014-08-21 18:47 ` Guenter Roeck
0 siblings, 2 replies; 4+ messages in thread
From: Mika Westerberg @ 2014-08-19 11:57 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: Guenter Roeck, Mika Westerberg, linux-kernel
There is no need to store the return value of misc_deregister() in a
variable. Instead we can just return the value directly.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/watchdog/ts72xx_wdt.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c
index afa9d6ef353a..dee9c6cbe6df 100644
--- a/drivers/watchdog/ts72xx_wdt.c
+++ b/drivers/watchdog/ts72xx_wdt.c
@@ -428,11 +428,7 @@ static int ts72xx_wdt_probe(struct platform_device *pdev)
static int ts72xx_wdt_remove(struct platform_device *pdev)
{
- int error;
-
- error = misc_deregister(&ts72xx_wdt_miscdev);
-
- return error;
+ return misc_deregister(&ts72xx_wdt_miscdev);
}
static struct platform_driver ts72xx_wdt_driver = {
--
2.1.0.rc1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove
2014-08-19 11:57 [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove Mika Westerberg
@ 2014-08-19 14:59 ` Guenter Roeck
2014-08-19 15:14 ` Mika Westerberg
2014-08-21 18:47 ` Guenter Roeck
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2014-08-19 14:59 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Wim Van Sebroeck, linux-kernel
On Tue, Aug 19, 2014 at 02:57:12PM +0300, Mika Westerberg wrote:
> There is no need to store the return value of misc_deregister() in a
> variable. Instead we can just return the value directly.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/watchdog/ts72xx_wdt.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c
> index afa9d6ef353a..dee9c6cbe6df 100644
> --- a/drivers/watchdog/ts72xx_wdt.c
> +++ b/drivers/watchdog/ts72xx_wdt.c
> @@ -428,11 +428,7 @@ static int ts72xx_wdt_probe(struct platform_device *pdev)
>
> static int ts72xx_wdt_remove(struct platform_device *pdev)
> {
> - int error;
> -
> - error = misc_deregister(&ts72xx_wdt_miscdev);
> -
> - return error;
> + return misc_deregister(&ts72xx_wdt_miscdev);
Is that worth it, and does it even reduce code size ?
Converting the driver to use the watchdog infrastructure would make much more sense
(if someone can test the result).
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove
2014-08-19 14:59 ` Guenter Roeck
@ 2014-08-19 15:14 ` Mika Westerberg
0 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2014-08-19 15:14 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, linux-kernel
On Tue, Aug 19, 2014 at 07:59:16AM -0700, Guenter Roeck wrote:
> On Tue, Aug 19, 2014 at 02:57:12PM +0300, Mika Westerberg wrote:
> > There is no need to store the return value of misc_deregister() in a
> > variable. Instead we can just return the value directly.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> > drivers/watchdog/ts72xx_wdt.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c
> > index afa9d6ef353a..dee9c6cbe6df 100644
> > --- a/drivers/watchdog/ts72xx_wdt.c
> > +++ b/drivers/watchdog/ts72xx_wdt.c
> > @@ -428,11 +428,7 @@ static int ts72xx_wdt_probe(struct platform_device *pdev)
> >
> > static int ts72xx_wdt_remove(struct platform_device *pdev)
> > {
> > - int error;
> > -
> > - error = misc_deregister(&ts72xx_wdt_miscdev);
> > -
> > - return error;
> > + return misc_deregister(&ts72xx_wdt_miscdev);
>
> Is that worth it, and does it even reduce code size ?
Well, it makes that particular function look better.
> Converting the driver to use the watchdog infrastructure would make much more sense
> (if someone can test the result).
I agree that converting makes sense, but that is subject of a separate patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove
2014-08-19 11:57 [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove Mika Westerberg
2014-08-19 14:59 ` Guenter Roeck
@ 2014-08-21 18:47 ` Guenter Roeck
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-08-21 18:47 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Wim Van Sebroeck, linux-kernel
On Tue, Aug 19, 2014 at 02:57:12PM +0300, Mika Westerberg wrote:
> There is no need to store the return value of misc_deregister() in a
> variable. Instead we can just return the value directly.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-21 18:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-19 11:57 [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove Mika Westerberg
2014-08-19 14:59 ` Guenter Roeck
2014-08-19 15:14 ` Mika Westerberg
2014-08-21 18:47 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome