* [PATCH] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
@ 2014-08-22 12:59 Rasmus Villemoes
2014-08-22 14:06 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Rasmus Villemoes @ 2014-08-22 12:59 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Rasmus Villemoes
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.h b/drivers/usb/gadget/udc/fusb300_udc.h
index ae811d8..ad39f89 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.h
+++ b/drivers/usb/gadget/udc/fusb300_udc.h
@@ -12,7 +12,7 @@
#ifndef __FUSB300_UDC_H__
-#define __FUSB300_UDC_H_
+#define __FUSB300_UDC_H__
#include <linux/kernel.h>
--
1.9.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
2014-08-22 12:59 [PATCH] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard Rasmus Villemoes
@ 2014-08-22 14:06 ` Felipe Balbi
2014-08-22 14:44 ` [PATCH v2] " Rasmus Villemoes
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2014-08-22 14:06 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Fri, Aug 22, 2014 at 02:59:32PM +0200, Rasmus Villemoes wrote:
you need a commit log. Has this always been there ? Which commit are you
fixing ?
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/fusb300_udc.h b/drivers/usb/gadget/udc/fusb300_udc.h
> index ae811d8..ad39f89 100644
> --- a/drivers/usb/gadget/udc/fusb300_udc.h
> +++ b/drivers/usb/gadget/udc/fusb300_udc.h
> @@ -12,7 +12,7 @@
>
>
> #ifndef __FUSB300_UDC_H__
> -#define __FUSB300_UDC_H_
> +#define __FUSB300_UDC_H__
>
> #include <linux/kernel.h>
>
> --
> 1.9.2
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
2014-08-22 14:06 ` Felipe Balbi
@ 2014-08-22 14:44 ` Rasmus Villemoes
2014-08-22 14:48 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Rasmus Villemoes @ 2014-08-22 14:44 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Rasmus Villemoes
Clearly this was meant to be an include guard, but a trailing
underscore was missing. It has been this way since the file was
introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.h b/drivers/usb/gadget/udc/fusb300_udc.h
index ae811d8..ad39f89 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.h
+++ b/drivers/usb/gadget/udc/fusb300_udc.h
@@ -12,7 +12,7 @@
#ifndef __FUSB300_UDC_H__
-#define __FUSB300_UDC_H_
+#define __FUSB300_UDC_H__
#include <linux/kernel.h>
--
2.0.4
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
2014-08-22 14:44 ` [PATCH v2] " Rasmus Villemoes
@ 2014-08-22 14:48 ` Felipe Balbi
2014-08-22 15:21 ` Rasmus Villemoes
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2014-08-22 14:48 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
> Clearly this was meant to be an include guard, but a trailing
> underscore was missing. It has been this way since the file was
> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
>
right here you need to have:
Fixes: 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver")
Cc: <stable@vger.kernel.org>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/fusb300_udc.h b/drivers/usb/gadget/udc/fusb300_udc.h
> index ae811d8..ad39f89 100644
> --- a/drivers/usb/gadget/udc/fusb300_udc.h
> +++ b/drivers/usb/gadget/udc/fusb300_udc.h
> @@ -12,7 +12,7 @@
>
>
> #ifndef __FUSB300_UDC_H__
> -#define __FUSB300_UDC_H_
> +#define __FUSB300_UDC_H__
>
> #include <linux/kernel.h>
>
> --
> 2.0.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
2014-08-22 14:48 ` Felipe Balbi
@ 2014-08-22 15:21 ` Rasmus Villemoes
2014-08-22 15:58 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Rasmus Villemoes @ 2014-08-22 15:21 UTC (permalink / raw)
To: balbi; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
Felipe Balbi <balbi@ti.com> writes:
> On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
>> Clearly this was meant to be an include guard, but a trailing
>> underscore was missing. It has been this way since the file was
>> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
>>
>
> right here you need to have:
>
> Fixes: 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver")
> Cc: <stable@vger.kernel.org>
Really? I can't see that it satisfies the
Documentation/stable_kernel_rules.txt. There's no chance of build error, since the
file is only included directly from a single .c file. As you can see on
LKML I've sent a few handfuls of similar patches all over the tree; IMHO
none of them qualify for stable.
If you insist, I'll add the Fixes and Cc tags.
Thanks,
Rasmus
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
2014-08-22 15:21 ` Rasmus Villemoes
@ 2014-08-22 15:58 ` Felipe Balbi
2014-08-25 8:30 ` [PATCH v3] " Rasmus Villemoes
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2014-08-22 15:58 UTC (permalink / raw)
To: Rasmus Villemoes; +Cc: balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
Hi,
On Fri, Aug 22, 2014 at 05:21:12PM +0200, Rasmus Villemoes wrote:
> Felipe Balbi <balbi@ti.com> writes:
>
> > On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
> >> Clearly this was meant to be an include guard, but a trailing
> >> underscore was missing. It has been this way since the file was
> >> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
> >>
> >
> > right here you need to have:
> >
> > Fixes: 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver")
> > Cc: <stable@vger.kernel.org>
>
> Really? I can't see that it satisfies the
> Documentation/stable_kernel_rules.txt. There's no chance of build error, since the
> file is only included directly from a single .c file. As you can see on
> LKML I've sent a few handfuls of similar patches all over the tree; IMHO
> none of them qualify for stable.
>
> If you insist, I'll add the Fixes and Cc tags.
it's a bug fix nevertheless.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v3] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard
2014-08-22 15:58 ` Felipe Balbi
@ 2014-08-25 8:30 ` Rasmus Villemoes
0 siblings, 0 replies; 7+ messages in thread
From: Rasmus Villemoes @ 2014-08-25 8:30 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Rasmus Villemoes, stable
Clearly this was meant to be an include guard, but a trailing
underscore was missing. It has been this way since the file was
introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
Fixes: 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
Notes:
v2: Add proper commit message.
v3: Add "Fixes:" and "Cc: stable" tags as requested by Felipe Balbi.
drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.h b/drivers/usb/gadget/udc/fusb300_udc.h
index ae811d8..ad39f89 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.h
+++ b/drivers/usb/gadget/udc/fusb300_udc.h
@@ -12,7 +12,7 @@
#ifndef __FUSB300_UDC_H__
-#define __FUSB300_UDC_H_
+#define __FUSB300_UDC_H__
#include <linux/kernel.h>
--
2.0.4
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-08-25 8:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 12:59 [PATCH] drivers: usb: gadget: fusb300_udc.h: Fix typo in include guard Rasmus Villemoes
2014-08-22 14:06 ` Felipe Balbi
2014-08-22 14:44 ` [PATCH v2] " Rasmus Villemoes
2014-08-22 14:48 ` Felipe Balbi
2014-08-22 15:21 ` Rasmus Villemoes
2014-08-22 15:58 ` Felipe Balbi
2014-08-25 8:30 ` [PATCH v3] " Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®