From: Morten Rasmussen <morten.rasmussen@arm.com>
To: peterz@infradead.org, mingo@redhat.com
Cc: dietmar.eggemann@arm.com, pjt@google.com, bsegall@google.com,
vincent.guittot@linaro.org, nicolas.pitre@linaro.org,
mturquette@linaro.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org,
Morten Rasmussen <morten.rasmussen@arm.com>
Subject: [PATCH 4/7] arm: Micro-architecture invariant load tracking support
Date: Mon, 22 Sep 2014 17:24:04 +0100 [thread overview]
Message-ID: <1411403047-32010-5-git-send-email-morten.rasmussen@arm.com> (raw)
In-Reply-To: <1411403047-32010-1-git-send-email-morten.rasmussen@arm.com>
Adds micro-architecture difference into scheduler load-tracking
scale-invariance correction factor for big.LITTLE systems. The factor is
now:
(current_freq(cpu) * uarch_factor(cpu) * SCHED_CAPACITY_SCALE) /
(max_freq(cpu) * max_uarch_factor)
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
---
arch/arm/kernel/topology.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
index 3e9a979..9f499e2 100644
--- a/arch/arm/kernel/topology.c
+++ b/arch/arm/kernel/topology.c
@@ -79,6 +79,9 @@ static unsigned long *__cpu_capacity;
static unsigned long middle_capacity = 1;
+static unsigned long max_raw_capacity = 1;
+static DEFINE_PER_CPU(unsigned long, cpu_raw_capacity);
+
/*
* Iterate all CPUs' descriptor in DT and compute the efficiency
* (as per table_efficiency). Also calculate a middle efficiency
@@ -117,6 +120,9 @@ static void __init parse_dt_topology(void)
if (cpu_eff->compatible == NULL)
continue;
+ per_cpu(cpu_raw_capacity, cpu) = cpu_eff->efficiency;
+ max_raw_capacity = max(max_raw_capacity, cpu_eff->efficiency);
+
rate = of_get_property(cn, "clock-frequency", &len);
if (!rate || len != 4) {
pr_err("%s missing clock-frequency property\n",
@@ -173,7 +179,8 @@ static void update_cpu_capacity(unsigned int cpu)
* Scheduler load-tracking scale-invariance
*
* Provides the scheduler with a scale-invariance correction factor that
- * compensates for frequency scaling.
+ * compensates for frequency scaling and micro-architecture differences between
+ * cpus.
*/
static DEFINE_PER_CPU(atomic_long_t, cpu_curr_freq);
@@ -195,11 +202,15 @@ unsigned long arch_scale_load_capacity(int cpu)
{
unsigned long curr = atomic_long_read(&per_cpu(cpu_curr_freq, cpu));
unsigned long max = atomic_long_read(&per_cpu(cpu_max_freq, cpu));
+ unsigned long ret;
- if (!max)
+ if (!max || !per_cpu(cpu_raw_capacity, cpu))
return SCHED_CAPACITY_SCALE;
- return (curr * SCHED_CAPACITY_SCALE) / max;
+ ret = (curr * SCHED_CAPACITY_SCALE) / max;
+ ret = (ret * per_cpu(cpu_raw_capacity, cpu)) / max_raw_capacity;
+
+ return ret;
}
#else
--
1.7.9.5
next prev parent reply other threads:[~2014-09-22 16:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 16:24 [PATCH 0/7] sched: Scale-invariant per-entity load-tracking Morten Rasmussen
2014-09-22 16:24 ` [PATCH 1/7] sched: Introduce scale-invariant load tracking Morten Rasmussen
2014-09-25 13:48 ` Vincent Guittot
2014-09-25 17:23 ` Morten Rasmussen
2014-09-26 7:36 ` Vincent Guittot
2014-09-26 9:38 ` Morten Rasmussen
2014-10-02 20:34 ` Peter Zijlstra
2014-10-08 11:00 ` Morten Rasmussen
2014-10-08 11:21 ` Vincent Guittot
2014-10-08 13:53 ` Morten Rasmussen
2014-10-08 14:08 ` Vincent Guittot
2014-10-08 14:16 ` Morten Rasmussen
2014-10-08 11:38 ` Vincent Guittot
2014-10-08 14:05 ` Morten Rasmussen
2014-10-10 9:07 ` Peter Zijlstra
2014-10-08 0:50 ` Yuyang Du
2014-10-08 12:54 ` Dietmar Eggemann
2014-10-10 9:16 ` Peter Zijlstra
2014-10-10 9:14 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 2/7] cpufreq: Architecture specific callback for frequency changes Morten Rasmussen
2014-10-08 6:07 ` Mike Turquette
2014-10-08 6:26 ` [PATCH RFC 0/2] introduce capacity_ops to CFS Mike Turquette
2014-10-08 6:26 ` [PATCH RFC 1/2] sched: cfs: introduce capacity_ops Mike Turquette
2014-10-08 8:37 ` Peter Zijlstra
[not found] ` <20141008232836.4379.3339@quantum>
2014-10-09 9:00 ` Peter Zijlstra
[not found] ` <20141009173433.4379.58492@quantum>
2014-10-09 19:00 ` Peter Zijlstra
2014-10-08 6:26 ` [PATCH RFC 2/2] cpufreq: arm_big_little: provide cpu capacity Mike Turquette
2014-10-08 15:48 ` Morten Rasmussen
[not found] ` <20141008223732.4379.78047@quantum>
2014-10-09 9:02 ` Peter Zijlstra
[not found] ` <20141009172513.4379.56718@quantum>
2014-10-09 17:38 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 3/7] arm: Frequency invariant scheduler load-tracking support Morten Rasmussen
2014-09-22 16:24 ` Morten Rasmussen [this message]
2014-09-22 16:24 ` [PATCH 5/7] sched: Implement usage tracking Morten Rasmussen
2014-09-22 16:24 ` [PATCH 6/7] sched: Make sched entity usage tracking scale-invariant Morten Rasmussen
2014-09-22 17:13 ` bsegall
2014-09-23 13:35 ` Morten Rasmussen
2014-10-02 21:04 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 7/7] sched: Track sched_entity usage contributions Morten Rasmussen
2014-09-22 17:09 ` bsegall
2014-09-23 13:59 ` Morten Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411403047-32010-5-git-send-email-morten.rasmussen@arm.com \
--to=morten.rasmussen@arm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@linaro.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®