From: Morten Rasmussen <morten.rasmussen@arm.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: "peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
Dietmar Eggemann <Dietmar.Eggemann@arm.com>,
"pjt@google.com" <pjt@google.com>,
"bsegall@google.com" <bsegall@google.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tuukka.tikkanen@linaro.org" <tuukka.tikkanen@linaro.org>
Subject: Re: [PATCH RFC 2/2] cpufreq: arm_big_little: provide cpu capacity
Date: Wed, 8 Oct 2014 16:48:51 +0100 [thread overview]
Message-ID: <20141008154851.GF1788@e105550-lin.cambridge.arm.com> (raw)
In-Reply-To: <1412749572-29449-3-git-send-email-mturquette@linaro.org>
On Wed, Oct 08, 2014 at 07:26:12AM +0100, Mike Turquette wrote:
> Move the cpu capacity bits out of arch/arm/ and into the CPUfreq driver.
> Not all ARM devices will use CPUfreq and it is unsafe to assume as such
> in topology.c.
>
> Instead, use the new capacity_ops introduced into CFS. If this code is
> generic enough then it could be factored and shared via a header to make
> it easier for other CPUfreq drivers to take advantage of it.
>
> Signed-off-by: Mike Turquette <mturquette@linaro.org>
> ---
> This approach simply builds on top of Morten's series. I am not sure
> that the per-cpu method is the best way to go in the future. And if so I
> imagine that the CPUfreq core could provide everything except for the
> cpu_eff part.
>
> In general I think that the overlap between CPUfreq drivers and
> arch/arm/kernel/topology.c is something that needs to addresssed soon,
> as both pieces of code are re-inventing parts of each other.
I think it would be easier to deal with the capacity scaling if we split
it into two scaling factors (like Vincent proposed by using the existing
arch_scale_{cpu,freq}_capacity() functions). Then whatever handles
frequency scaling doesn't have to coordinate with uarch scaling. Both
would be factors in the range 0..1024. We would just multiply the two
scaling factors in fair.c when needed (and shift as necessary).
Wouldn't that make it simple enough that we can implement it in a
generic way in arch/*/topology.c with a bit of help from the cpufreq
framework without involving any drivers directly? Or is that just
wishful thinking? :)
next prev parent reply other threads:[~2014-10-08 15:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 16:24 [PATCH 0/7] sched: Scale-invariant per-entity load-tracking Morten Rasmussen
2014-09-22 16:24 ` [PATCH 1/7] sched: Introduce scale-invariant load tracking Morten Rasmussen
2014-09-25 13:48 ` Vincent Guittot
2014-09-25 17:23 ` Morten Rasmussen
2014-09-26 7:36 ` Vincent Guittot
2014-09-26 9:38 ` Morten Rasmussen
2014-10-02 20:34 ` Peter Zijlstra
2014-10-08 11:00 ` Morten Rasmussen
2014-10-08 11:21 ` Vincent Guittot
2014-10-08 13:53 ` Morten Rasmussen
2014-10-08 14:08 ` Vincent Guittot
2014-10-08 14:16 ` Morten Rasmussen
2014-10-08 11:38 ` Vincent Guittot
2014-10-08 14:05 ` Morten Rasmussen
2014-10-10 9:07 ` Peter Zijlstra
2014-10-08 0:50 ` Yuyang Du
2014-10-08 12:54 ` Dietmar Eggemann
2014-10-10 9:16 ` Peter Zijlstra
2014-10-10 9:14 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 2/7] cpufreq: Architecture specific callback for frequency changes Morten Rasmussen
2014-10-08 6:07 ` Mike Turquette
2014-10-08 6:26 ` [PATCH RFC 0/2] introduce capacity_ops to CFS Mike Turquette
2014-10-08 6:26 ` [PATCH RFC 1/2] sched: cfs: introduce capacity_ops Mike Turquette
2014-10-08 8:37 ` Peter Zijlstra
[not found] ` <20141008232836.4379.3339@quantum>
2014-10-09 9:00 ` Peter Zijlstra
[not found] ` <20141009173433.4379.58492@quantum>
2014-10-09 19:00 ` Peter Zijlstra
2014-10-08 6:26 ` [PATCH RFC 2/2] cpufreq: arm_big_little: provide cpu capacity Mike Turquette
2014-10-08 15:48 ` Morten Rasmussen [this message]
[not found] ` <20141008223732.4379.78047@quantum>
2014-10-09 9:02 ` Peter Zijlstra
[not found] ` <20141009172513.4379.56718@quantum>
2014-10-09 17:38 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 3/7] arm: Frequency invariant scheduler load-tracking support Morten Rasmussen
2014-09-22 16:24 ` [PATCH 4/7] arm: Micro-architecture invariant load tracking support Morten Rasmussen
2014-09-22 16:24 ` [PATCH 5/7] sched: Implement usage tracking Morten Rasmussen
2014-09-22 16:24 ` [PATCH 6/7] sched: Make sched entity usage tracking scale-invariant Morten Rasmussen
2014-09-22 17:13 ` bsegall
2014-09-23 13:35 ` Morten Rasmussen
2014-10-02 21:04 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 7/7] sched: Track sched_entity usage contributions Morten Rasmussen
2014-09-22 17:09 ` bsegall
2014-09-23 13:59 ` Morten Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008154851.GF1788@e105550-lin.cambridge.arm.com \
--to=morten.rasmussen@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=bsegall@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@linaro.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rjw@rjwysocki.net \
--cc=tuukka.tikkanen@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®