mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiubo Li <Li.Xiubo@freescale.com>
To: <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <dp@opensource.wolfsonmicro.com>,
	Xiubo Li <Li.Xiubo@freescale.com>
Subject: [PATCH 1/6] regmap: cache: Sort include headers alphabetically
Date: Thu, 9 Oct 2014 17:02:52 +0800	[thread overview]
Message-ID: <1412845377-17134-2-git-send-email-Li.Xiubo@freescale.com> (raw)
In-Reply-To: <1412845377-17134-1-git-send-email-Li.Xiubo@freescale.com>

If the inlcude headers aren't sorted alphabetically, then the
logical choice is to append new ones, however that creates a
lot of potential for conflicts or duplicates because every change
will then add new includes in the same location.

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
 drivers/base/regmap/regcache-flat.c   | 2 +-
 drivers/base/regmap/regcache-lzo.c    | 2 +-
 drivers/base/regmap/regcache-rbtree.c | 4 ++--
 drivers/base/regmap/regcache.c        | 8 ++++----
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/base/regmap/regcache-flat.c b/drivers/base/regmap/regcache-flat.c
index d9762e4..0246f44 100644
--- a/drivers/base/regmap/regcache-flat.c
+++ b/drivers/base/regmap/regcache-flat.c
@@ -10,9 +10,9 @@
  * published by the Free Software Foundation.
  */
 
-#include <linux/slab.h>
 #include <linux/device.h>
 #include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include "internal.h"
 
diff --git a/drivers/base/regmap/regcache-lzo.c b/drivers/base/regmap/regcache-lzo.c
index e210a6d..2d53f6f 100644
--- a/drivers/base/regmap/regcache-lzo.c
+++ b/drivers/base/regmap/regcache-lzo.c
@@ -10,9 +10,9 @@
  * published by the Free Software Foundation.
  */
 
-#include <linux/slab.h>
 #include <linux/device.h>
 #include <linux/lzo.h>
+#include <linux/slab.h>
 
 #include "internal.h"
 
diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c
index f3e8fe0..d453a2c 100644
--- a/drivers/base/regmap/regcache-rbtree.c
+++ b/drivers/base/regmap/regcache-rbtree.c
@@ -10,11 +10,11 @@
  * published by the Free Software Foundation.
  */
 
-#include <linux/slab.h>
-#include <linux/device.h>
 #include <linux/debugfs.h>
+#include <linux/device.h>
 #include <linux/rbtree.h>
 #include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include "internal.h"
 
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index f1280dc..4896804 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -10,12 +10,12 @@
  * published by the Free Software Foundation.
  */
 
-#include <linux/slab.h>
-#include <linux/export.h>
-#include <linux/device.h>
-#include <trace/events/regmap.h>
 #include <linux/bsearch.h>
+#include <linux/device.h>
+#include <linux/export.h>
+#include <linux/slab.h>
 #include <linux/sort.h>
+#include <trace/events/regmap.h>
 
 #include "internal.h"
 
-- 
2.1.0.27.g96db324


  reply	other threads:[~2014-10-09  9:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09  9:02 [PATCH 0/6] regmap: cache: cleanup and fix bugs Xiubo Li
2014-10-09  9:02 ` Xiubo Li [this message]
2014-10-13 10:39   ` [PATCH 1/6] regmap: cache: Sort include headers alphabetically Mark Brown
2014-10-09  9:02 ` [PATCH 2/6] regmap: cache: cleanup regcache_hw_init() Xiubo Li
2014-10-13 10:47   ` Mark Brown
2014-10-14  1:52     ` Li.Xiubo
2014-10-09  9:02 ` [PATCH 3/6] regmap: cache: fix errno in regcache_hw_init() Xiubo Li
2014-10-13 10:48   ` Mark Brown
2014-10-09  9:02 ` [PATCH 4/6] regmap: cache: speed regcache_hw_init() up Xiubo Li
2014-10-13 10:48   ` Mark Brown
2014-10-09  9:02 ` [PATCH 5/6] regmap: cache: use kmalloc_array instead of kmalloc Xiubo Li
2014-10-13 10:49   ` Mark Brown
2014-10-09  9:02 ` [PATCH 6/6] regmap: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error Xiubo Li
2014-10-13 10:54   ` Mark Brown
2014-10-14  2:03     ` Li.Xiubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412845377-17134-2-git-send-email-Li.Xiubo@freescale.com \
    --to=li.xiubo@freescale.com \
    --cc=broonie@kernel.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®