From: Xiubo Li <Li.Xiubo@freescale.com>
To: <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <dp@opensource.wolfsonmicro.com>,
Xiubo Li <Li.Xiubo@freescale.com>
Subject: [PATCH 5/6] regmap: cache: use kmalloc_array instead of kmalloc
Date: Thu, 9 Oct 2014 17:02:56 +0800 [thread overview]
Message-ID: <1412845377-17134-6-git-send-email-Li.Xiubo@freescale.com> (raw)
In-Reply-To: <1412845377-17134-1-git-send-email-Li.Xiubo@freescale.com>
This patch fixes checkpatch.pl warning for regmap cache.
WARNING : prefer kmalloc_array over kmalloc with multiply
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
drivers/base/regmap/regcache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 45ab909..a06bcd2 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -61,8 +61,8 @@ static int regcache_hw_init(struct regmap *map)
if (!regmap_volatile(map, i * map->reg_stride))
count++;
- map->reg_defaults = kmalloc(count * sizeof(struct reg_default),
- GFP_KERNEL);
+ map->reg_defaults = kmalloc_array(count, sizeof(struct reg_default),
+ GFP_KERNEL);
if (!map->reg_defaults) {
ret = -ENOMEM;
goto err_free;
--
2.1.0.27.g96db324
next prev parent reply other threads:[~2014-10-09 9:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 9:02 [PATCH 0/6] regmap: cache: cleanup and fix bugs Xiubo Li
2014-10-09 9:02 ` [PATCH 1/6] regmap: cache: Sort include headers alphabetically Xiubo Li
2014-10-13 10:39 ` Mark Brown
2014-10-09 9:02 ` [PATCH 2/6] regmap: cache: cleanup regcache_hw_init() Xiubo Li
2014-10-13 10:47 ` Mark Brown
2014-10-14 1:52 ` Li.Xiubo
2014-10-09 9:02 ` [PATCH 3/6] regmap: cache: fix errno in regcache_hw_init() Xiubo Li
2014-10-13 10:48 ` Mark Brown
2014-10-09 9:02 ` [PATCH 4/6] regmap: cache: speed regcache_hw_init() up Xiubo Li
2014-10-13 10:48 ` Mark Brown
2014-10-09 9:02 ` Xiubo Li [this message]
2014-10-13 10:49 ` [PATCH 5/6] regmap: cache: use kmalloc_array instead of kmalloc Mark Brown
2014-10-09 9:02 ` [PATCH 6/6] regmap: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error Xiubo Li
2014-10-13 10:54 ` Mark Brown
2014-10-14 2:03 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412845377-17134-6-git-send-email-Li.Xiubo@freescale.com \
--to=li.xiubo@freescale.com \
--cc=broonie@kernel.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®