From: Mark Brown <broonie@kernel.org>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: linux-kernel@vger.kernel.org, dp@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init().
Date: Mon, 13 Oct 2014 12:47:20 +0200 [thread overview]
Message-ID: <20141013104720.GM27755@sirena.org.uk> (raw)
In-Reply-To: <1412845377-17134-3-git-send-email-Li.Xiubo@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On Thu, Oct 09, 2014 at 05:02:53PM +0800, Xiubo Li wrote:
> Remove the redundant code for regmap cache.
Applied, thanks. With changes like this it is much better if the
changelog explains why the code is redundant - say in words that the
value used is never referenced and looking up the value has no side
effects.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-13 10:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 9:02 [PATCH 0/6] regmap: cache: cleanup and fix bugs Xiubo Li
2014-10-09 9:02 ` [PATCH 1/6] regmap: cache: Sort include headers alphabetically Xiubo Li
2014-10-13 10:39 ` Mark Brown
2014-10-09 9:02 ` [PATCH 2/6] regmap: cache: cleanup regcache_hw_init() Xiubo Li
2014-10-13 10:47 ` Mark Brown [this message]
2014-10-14 1:52 ` Li.Xiubo
2014-10-09 9:02 ` [PATCH 3/6] regmap: cache: fix errno in regcache_hw_init() Xiubo Li
2014-10-13 10:48 ` Mark Brown
2014-10-09 9:02 ` [PATCH 4/6] regmap: cache: speed regcache_hw_init() up Xiubo Li
2014-10-13 10:48 ` Mark Brown
2014-10-09 9:02 ` [PATCH 5/6] regmap: cache: use kmalloc_array instead of kmalloc Xiubo Li
2014-10-13 10:49 ` Mark Brown
2014-10-09 9:02 ` [PATCH 6/6] regmap: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error Xiubo Li
2014-10-13 10:54 ` Mark Brown
2014-10-14 2:03 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013104720.GM27755@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®