* [PATCH] ASoC: dapm: Remove redundant cast
@ 2014-10-21 15:01 Rasmus Villemoes
2014-10-21 21:24 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2014-10-21 15:01 UTC (permalink / raw)
To: Mark Brown, Takashi Iwai; +Cc: alsa-devel, linux-kernel, Rasmus Villemoes
Both path->name and e->texts[i] have type const char*, so the cast is
slightly confusing and certainly unnecessary.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
sound/soc/soc-dapm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index c61cb9c..39f992b 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -496,7 +496,7 @@ static int dapm_connect_mux(struct snd_soc_dapm_context *dapm,
list_add(&path->list, &dapm->card->paths);
list_add(&path->list_sink, &dest->sources);
list_add(&path->list_source, &src->sinks);
- path->name = (char*)e->texts[i];
+ path->name = e->texts[i];
if (i == item)
path->connect = 1;
else
--
2.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: dapm: Remove redundant cast
2014-10-21 15:01 [PATCH] ASoC: dapm: Remove redundant cast Rasmus Villemoes
@ 2014-10-21 21:24 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-10-21 21:24 UTC (permalink / raw)
To: Rasmus Villemoes; +Cc: Takashi Iwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
On Tue, Oct 21, 2014 at 05:01:15PM +0200, Rasmus Villemoes wrote:
> Both path->name and e->texts[i] have type const char*, so the cast is
> slightly confusing and certainly unnecessary.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-21 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-21 15:01 [PATCH] ASoC: dapm: Remove redundant cast Rasmus Villemoes
2014-10-21 21:24 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®