From: Martin Kepplinger <martink@posteo.de>
To: peterz@infradead.org
Cc: mingo@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org,
Martin Kepplinger <martink@posteo.de>
Subject: [PATCH 4/6] input: gtco: use bitops' sign_extend8
Date: Mon, 15 Dec 2014 17:18:35 +0100 [thread overview]
Message-ID: <1418660317-21750-5-git-send-email-martink@posteo.de> (raw)
In-Reply-To: <1418660317-21750-1-git-send-email-martink@posteo.de>
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/input/tablet/gtco.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
index 8580456..25b3834 100644
--- a/drivers/input/tablet/gtco.c
+++ b/drivers/input/tablet/gtco.c
@@ -59,7 +59,7 @@ Scott Hill shill@gtcocalcomp.com
#include <asm/uaccess.h>
#include <asm/unaligned.h>
#include <asm/byteorder.h>
-
+#include <linux/bitops.h>
#include <linux/usb/input.h>
@@ -666,13 +666,8 @@ static void gtco_urb_callback(struct urb *urbinfo)
case 4:
/* Tilt */
- /* Sign extend these 7 bit numbers. */
- if (device->buffer[6] & 0x40)
- device->buffer[6] |= 0x80;
-
- if (device->buffer[7] & 0x40)
- device->buffer[7] |= 0x80;
-
+ device->buffer[6] = sign_extend8(device->buffer[6], 6);
+ device->buffer[7] = sign_extend8(device->buffer[6], 6);
valsigned = (device->buffer[6]);
input_report_abs(inputdev, ABS_TILT_X, (s32)valsigned);
--
2.1.3
next prev parent reply other threads:[~2014-12-15 16:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 16:18 add sign-extend functions for 8 and 16 bit values Martin Kepplinger
2014-12-15 16:18 ` [PATCH 1/6] bitops.h: add sign_extend8 function Martin Kepplinger
2014-12-15 16:18 ` [PATCH 2/6] bitops.h: add sign_extend16 function Martin Kepplinger
2014-12-15 17:58 ` Martin Kepplinger
2014-12-15 16:18 ` [PATCH 3/6] hwmon: jc42: use bitops' sign_extend16 Martin Kepplinger
2014-12-15 21:29 ` Guenter Roeck
2014-12-16 7:17 ` Martin Kepplinger
2015-01-11 10:34 ` Martin Kepplinger
2015-01-11 16:52 ` Guenter Roeck
2015-01-12 17:36 ` Martin Kepplinger
2014-12-15 16:18 ` Martin Kepplinger [this message]
2014-12-15 16:18 ` [PATCH 5/6] rtc: use sign_extend8 instead of manual conversion Martin Kepplinger
2014-12-15 16:18 ` [PATCH 6/6] media: stb0899: use sign_extend8 instead of manual work Martin Kepplinger
2014-12-15 17:17 ` add sign-extend functions for 8 and 16 bit values Peter Zijlstra
2014-12-15 17:54 ` [PATCH] bitops.h: add sign_extend64() function Martin Kepplinger
2014-12-15 18:06 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418660317-21750-5-git-send-email-martink@posteo.de \
--to=martink@posteo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®