From: Martin Kepplinger <martink@posteo.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: peterz@infradead.org, mingo@kernel.org, tytso@mit.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] hwmon: jc42: use bitops' sign_extend16
Date: Mon, 12 Jan 2015 18:36:12 +0100 [thread overview]
Message-ID: <54B4060C.4010004@posteo.de> (raw)
In-Reply-To: <54B2AA69.80305@roeck-us.net>
Am 2015-01-11 um 17:52 schrieb Guenter Roeck:
> On 01/11/2015 02:34 AM, Martin Kepplinger wrote:
>> Am 2014-12-16 um 08:17 schrieb Martin Kepplinger:
>>> Am 2014-12-15 um 22:29 schrieb Guenter Roeck:
>>>> On Mon, Dec 15, 2014 at 05:18:34PM +0100, Martin Kepplinger wrote:
>>>>> ---
>>>>
>>>> Some description would be nice. Also, please consider adding
>>>> relevant subsystem mailing lists and maintainers to your patches.
>>>>
>>>
>>> I shouldn't have added the Signed-off-by line to some of them. Sorry.
>>>
>>> The driver-patches are meant to be examples of what can be changed if
>>> the sign_extend functions are added. I don't know if they are taken and
>>> planned to post the driver patches (probably more) thereafter, and of
>>> course to the relevant people.
>>
>> Is this sign_extendXX() set of functions considered to be added to
>> bitops.h ?
>>
>> Just checking if I can prepare some driver-patches (the ones I posted
>> are just examples, meant to be re-sent to relevant maintainers when it's
>> time), or not.
>>
>
> You should probably ask the question as response to patch 1/6.
>
> In general, it might be useful to send example patches like this one as
> RFC.
> Sending it as real patch and then saying "it is just an example" may result
> in the entire series being ignored. This is not a matter of Signed-off
> or not
> (originally I didn't even understand what you wanted to say with your
> reply),
> but a matter of a non-misleading headline.
>
> Thanks,
> Guenter
>
Thanks for the advice. I resent, https://lkml.org/lkml/2015/1/12/590
because the thing is easier than it might now seem, and hope that
doesn't add confusion.
thanks again,
martin
next prev parent reply other threads:[~2015-01-12 17:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 16:18 add sign-extend functions for 8 and 16 bit values Martin Kepplinger
2014-12-15 16:18 ` [PATCH 1/6] bitops.h: add sign_extend8 function Martin Kepplinger
2014-12-15 16:18 ` [PATCH 2/6] bitops.h: add sign_extend16 function Martin Kepplinger
2014-12-15 17:58 ` Martin Kepplinger
2014-12-15 16:18 ` [PATCH 3/6] hwmon: jc42: use bitops' sign_extend16 Martin Kepplinger
2014-12-15 21:29 ` Guenter Roeck
2014-12-16 7:17 ` Martin Kepplinger
2015-01-11 10:34 ` Martin Kepplinger
2015-01-11 16:52 ` Guenter Roeck
2015-01-12 17:36 ` Martin Kepplinger [this message]
2014-12-15 16:18 ` [PATCH 4/6] input: gtco: use bitops' sign_extend8 Martin Kepplinger
2014-12-15 16:18 ` [PATCH 5/6] rtc: use sign_extend8 instead of manual conversion Martin Kepplinger
2014-12-15 16:18 ` [PATCH 6/6] media: stb0899: use sign_extend8 instead of manual work Martin Kepplinger
2014-12-15 17:17 ` add sign-extend functions for 8 and 16 bit values Peter Zijlstra
2014-12-15 17:54 ` [PATCH] bitops.h: add sign_extend64() function Martin Kepplinger
2014-12-15 18:06 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4060C.4010004@posteo.de \
--to=martink@posteo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome