From: Martin Kepplinger <martink@posteo.de>
To: peterz@infradead.org
Cc: mingo@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org,
Martin Kepplinger <martink@posteo.de>
Subject: [PATCH 6/6] media: stb0899: use sign_extend8 instead of manual work
Date: Mon, 15 Dec 2014 17:18:37 +0100 [thread overview]
Message-ID: <1418660317-21750-7-git-send-email-martink@posteo.de> (raw)
In-Reply-To: <1418660317-21750-1-git-send-email-martink@posteo.de>
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/media/dvb-frontends/stb0899_algo.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/stb0899_algo.c b/drivers/media/dvb-frontends/stb0899_algo.c
index 93596e0..7bbcfde 100644
--- a/drivers/media/dvb-frontends/stb0899_algo.c
+++ b/drivers/media/dvb-frontends/stb0899_algo.c
@@ -19,6 +19,7 @@
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#include <linux/bitops.h>
#include "stb0899_drv.h"
#include "stb0899_priv.h"
#include "stb0899_reg.h"
@@ -1490,9 +1491,7 @@ enum stb0899_status stb0899_dvbs2_algo(struct stb0899_state *state)
/* Store signal parameters */
offsetfreq = STB0899_READ_S2REG(STB0899_S2DEMOD, CRL_FREQ);
- /* sign extend 30 bit value before using it in calculations */
- if (offsetfreq & (1 << 29))
- offsetfreq |= -1 << 30;
+ offsetfreq = sign_extend32(offset_freq, 29);
offsetfreq = offsetfreq / ((1 << 30) / 1000);
offsetfreq *= (internal->master_clk / 1000000);
--
2.1.3
next prev parent reply other threads:[~2014-12-15 16:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 16:18 add sign-extend functions for 8 and 16 bit values Martin Kepplinger
2014-12-15 16:18 ` [PATCH 1/6] bitops.h: add sign_extend8 function Martin Kepplinger
2014-12-15 16:18 ` [PATCH 2/6] bitops.h: add sign_extend16 function Martin Kepplinger
2014-12-15 17:58 ` Martin Kepplinger
2014-12-15 16:18 ` [PATCH 3/6] hwmon: jc42: use bitops' sign_extend16 Martin Kepplinger
2014-12-15 21:29 ` Guenter Roeck
2014-12-16 7:17 ` Martin Kepplinger
2015-01-11 10:34 ` Martin Kepplinger
2015-01-11 16:52 ` Guenter Roeck
2015-01-12 17:36 ` Martin Kepplinger
2014-12-15 16:18 ` [PATCH 4/6] input: gtco: use bitops' sign_extend8 Martin Kepplinger
2014-12-15 16:18 ` [PATCH 5/6] rtc: use sign_extend8 instead of manual conversion Martin Kepplinger
2014-12-15 16:18 ` Martin Kepplinger [this message]
2014-12-15 17:17 ` add sign-extend functions for 8 and 16 bit values Peter Zijlstra
2014-12-15 17:54 ` [PATCH] bitops.h: add sign_extend64() function Martin Kepplinger
2014-12-15 18:06 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418660317-21750-7-git-send-email-martink@posteo.de \
--to=martink@posteo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®