* [PATCH] skein: checkpatch: trailing whitespace
@ 2014-12-29 23:33 Andreas Siegling
2014-12-30 15:26 ` Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Siegling @ 2014-12-29 23:33 UTC (permalink / raw)
To: devel
Cc: gregkh, jason, eric.rost, nks, devel, linux-kernel, linux-kernel,
trivial, Andreas Siegling, Zhutao Lu
This small patch will fix the trailing whitespace in
drivers/staging/skein/skein_generic.c.
After applying the patch, there will only remain the checkpatch warning:
WARNING: Single statement macros should not use a do {} while (0) loop
in files which are in the directory drivers/staging/skein/
Signed-off-by: Andreas Siegling <andreas.siegling@fau.de>
Signed-off-by: Zhutao Lu <lvzhutao@gmail.com>
---
drivers/staging/skein/skein_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 85bd7d0..4eaae1d 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,7 @@ static int __init skein_generic_init(void)
return 0;
-
+
unreg512:
crypto_unregister_shash(&alg512);
unreg256:
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] skein: checkpatch: trailing whitespace
2014-12-29 23:33 [PATCH] skein: checkpatch: trailing whitespace Andreas Siegling
@ 2014-12-30 15:26 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2014-12-30 15:26 UTC (permalink / raw)
To: Andreas Siegling
Cc: devel, gregkh, eric.rost, nks, devel, linux-kernel, linux-kernel,
trivial, Zhutao Lu
Andreas,
On Tue, Dec 30, 2014 at 12:33:34AM +0100, Andreas Siegling wrote:
> This small patch will fix the trailing whitespace in
> drivers/staging/skein/skein_generic.c.
>
> After applying the patch, there will only remain the checkpatch warning:
> WARNING: Single statement macros should not use a do {} while (0) loop
> in files which are in the directory drivers/staging/skein/
>
> Signed-off-by: Andreas Siegling <andreas.siegling@fau.de>
> Signed-off-by: Zhutao Lu <lvzhutao@gmail.com>
Why do you have have two S-o-b's?
> ---
> drivers/staging/skein/skein_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 85bd7d0..4eaae1d 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -191,7 +191,7 @@ static int __init skein_generic_init(void)
>
> return 0;
>
> -
> +
Hmm, this extra line should just be deleted.
thx,
Jason.
> unreg512:
> crypto_unregister_shash(&alg512);
> unreg256:
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-30 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-29 23:33 [PATCH] skein: checkpatch: trailing whitespace Andreas Siegling
2014-12-30 15:26 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®