[PATCH 0/2] x86: earlyprintk cleanup

[PATCH 0/2] x86: earlyprintk cleanup

[Alexander Kuleshov]

The following two patches remove unused macro definitions from 
early_serial_console and early_printk x86 code.

Alexander Kuleshov (2):
  x86/early_serial_console: remove unused definitions
  x86/early_printk: remove unused definitions

 arch/x86/boot/early_serial_console.c | 5 -----
 arch/x86/kernel/early_printk.c       | 3 ---
 2 files changed, 8 deletions(-)

-- 
2.3.0.rc0.44.ga94655d.dirty

[PATCH 1/2] x86/early_serial_console: remove unused definitions

[Alexander Kuleshov]

TXR, RXR, IIR, LSR and MSR are not used anywhere

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 arch/x86/boot/early_serial_console.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 5df2869..9176135 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -6,15 +6,10 @@
 
 #define DLAB		0x80
 
-#define TXR             0       /*  Transmit register (WRITE) */
-#define RXR             0       /*  Receive register  (READ)  */
 #define IER             1       /*  Interrupt Enable          */
-#define IIR             2       /*  Interrupt ID              */
 #define FCR             2       /*  FIFO control              */
 #define LCR             3       /*  Line control              */
 #define MCR             4       /*  Modem control             */
-#define LSR             5       /*  Line Status               */
-#define MSR             6       /*  Modem Status              */
 #define DLL             0       /*  Divisor Latch Low         */
 #define DLH             1       /*  Divisor latch High        */
 
-- 
2.3.0.rc0.44.ga94655d.dirty

[PATCH 2/2] x86/early_printk: remove unused definitions

[Alexander Kuleshov]

RXR, IIR and MSR are not used

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 arch/x86/kernel/early_printk.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index 01d1c18..e8f317f 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -83,14 +83,11 @@ static int early_serial_base = 0x3f8;  /* ttyS0 */
 #define DLAB		0x80
 
 #define TXR             0       /*  Transmit register (WRITE) */
-#define RXR             0       /*  Receive register  (READ)  */
 #define IER             1       /*  Interrupt Enable          */
-#define IIR             2       /*  Interrupt ID              */
 #define FCR             2       /*  FIFO control              */
 #define LCR             3       /*  Line control              */
 #define MCR             4       /*  Modem control             */
 #define LSR             5       /*  Line Status               */
-#define MSR             6       /*  Modem Status              */
 #define DLL             0       /*  Divisor Latch Low         */
 #define DLH             1       /*  Divisor latch High        */
 
-- 
2.3.0.rc0.44.ga94655d.dirty

Re: [PATCH 0/2] x86: earlyprintk cleanup

[Thomas Gleixner]

On Mon, 19 Jan 2015, Alexander Kuleshov wrote:

> The following two patches remove unused macro definitions from 
> early_serial_console and early_printk x86 code.

Sigh. These mechanical 'follow the output of some code analyzer'
changes are really horrible.

Why not doing the obvious: Move the duplicated defines into a common
header file and be done with it?

And if you look deeper, then you'll notice that those defines are used
in two other files as well.

What's worse is that the whole set of defines is readily available in
include/uapi/linux/serial_reg.h already (just with different symbols).

So what's the point of these removal patches?

Thanks,

	tglx

Re: [PATCH 0/2] x86: earlyprintk cleanup

[Alexander Kuleshov]

Hello Thomas,

2015-01-20 16:29 GMT+06:00 Thomas Gleixner <tglx@linutronix.de>:
> On Mon, 19 Jan 2015, Alexander Kuleshov wrote:
>
>> The following two patches remove unused macro definitions from
>> early_serial_console and early_printk x86 code.
>
> Sigh. These mechanical 'follow the output of some code analyzer'
> changes are really horrible.
>
> Why not doing the obvious: Move the duplicated defines into a common
> header file and be done with it?
>
> And if you look deeper, then you'll notice that those defines are used
> in two other files as well.
>
> What's worse is that the whole set of defines is readily available in
> include/uapi/linux/serial_reg.h already (just with different symbols).
>
> So what's the point of these removal patches?
>

To get rid of unused code. Will it be better to move general serial
definitions to the arch/x86/include/asm/serial.h? Or it is wrong
place...

Thank you.

Re: [PATCH 0/2] x86: earlyprintk cleanup

[Thomas Gleixner]

On Tue, 20 Jan 2015, Alexander Kuleshov wrote:
> 2015-01-20 16:29 GMT+06:00 Thomas Gleixner <tglx@linutronix.de>:
> > On Mon, 19 Jan 2015, Alexander Kuleshov wrote:
> >
> >> The following two patches remove unused macro definitions from
> >> early_serial_console and early_printk x86 code.
> >
> > Sigh. These mechanical 'follow the output of some code analyzer'
> > changes are really horrible.
> >
> > Why not doing the obvious: Move the duplicated defines into a common
> > header file and be done with it?
> >
> > And if you look deeper, then you'll notice that those defines are used
> > in two other files as well.
> >
> > What's worse is that the whole set of defines is readily available in
> > include/uapi/linux/serial_reg.h already (just with different symbols).
> >
> > So what's the point of these removal patches?
> >
> 
> To get rid of unused code. Will it be better to move general serial
> definitions to the arch/x86/include/asm/serial.h? Or it is wrong
> place...

Care to read what I wrote before?