mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tolga Ceylan <tolga.ceylan@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Roxana Blaj <roxanagabriela10@gmail.com>,
	Ana Rey <anarey@gmail.com>, Rui Miguel Silva <rmfrfs@gmail.com>,
	Joe Perches <joe@perches.com>,
	Chaitra Ramaiah <linux.delve@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	tolga.ceylan@gmail.com
Subject: [PATCH 3/4] Staging: rtl9182u: r819xU_firmware: Replaced C99 comments with C89
Date: Thu, 19 Feb 2015 21:54:10 -0800	[thread overview]
Message-ID: <1424411651-15978-3-git-send-email-tolga.ceylan@gmail.com> (raw)
In-Reply-To: <1424411651-15978-1-git-send-email-tolga.ceylan@gmail.com>

Replaced C99 comments with C89.

Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
 drivers/staging/rtl8192u/r819xU_firmware.c | 33 +++++++++++++++---------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c
index 6a818c4..e7b2f33 100644
--- a/drivers/staging/rtl8192u/r819xU_firmware.c
+++ b/drivers/staging/rtl8192u/r819xU_firmware.c
@@ -47,7 +47,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 	u8		    index;
 
 	firmware_init_param(dev);
-	//Fragmentation might be required
+	/* Fragmentation might be required */
 	frag_threshold = pfirmware->cmdpacket_frag_thresold;
 	do {
 		if ((buffer_len - frag_offset) > frag_threshold) {
@@ -106,19 +106,20 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 
 }
 
-//-----------------------------------------------------------------------------
-// Procedure:    Check whether main code is download OK. If OK, turn on CPU
-//
-// Description:   CPU register locates in different page against general register.
-//			    Switch to CPU register in the begin and switch back before return
-//
-//
-// Arguments:   The pointer of the adapter
-//
-// Returns:
-//        NDIS_STATUS_FAILURE - the following initialization process should be terminated
-//        NDIS_STATUS_SUCCESS - if firmware initialization process success
-//-----------------------------------------------------------------------------
+/*
+ * Procedure:	Check whether main code is download OK. If OK, turn on CPU
+ *
+ * Description:	CPU register locates in different page against general register.
+ *	    Switch to CPU register in the begin and switch back before return
+ *
+ *
+ * Arguments:   The pointer of the adapter
+ *
+ * Returns:
+ *        NDIS_STATUS_FAILURE - the following initialization process should
+ *				be terminated
+ *        NDIS_STATUS_SUCCESS - if firmware initialization process success
+ */
 static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
 {
 	bool		rt_status = true;
@@ -221,7 +222,7 @@ bool init_firmware(struct net_device *dev)
 		/* it is called by reset */
 		rst_opt = OPT_SYSTEM_RESET;
 		starting_state = FW_INIT_STEP0_BOOT;
-		// TODO: system reset
+		/* TODO: system reset */
 
 	} else if (pfirmware->firmware_status == FW_STATUS_5_READY) {
 		/* it is called by Initialize */
@@ -290,7 +291,7 @@ bool init_firmware(struct net_device *dev)
 			 * will set polling bit when firmware code is also configured
 			 */
 			pfirmware->firmware_status = FW_STATUS_1_MOVE_BOOT_CODE;
-			//mdelay(1000);
+			/* mdelay(1000); */
 			/*
 			 * To initialize IMEM, CPU move code  from 0x80000080,
 			 * hence, we send 0x80 byte packet
-- 
2.3.0


  parent reply	other threads:[~2015-02-20  5:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  5:54 [PATCH 1/4] Staging: rtl8192u: r819xU_firmware: removed commented out variable Tolga Ceylan
2015-02-20  5:54 ` [PATCH 2/4] Staging: rtl8192u: r819xU_firmware: removed commented out assert Tolga Ceylan
2015-02-20  5:54 ` Tolga Ceylan [this message]
2015-02-20  5:54 ` [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma Tolga Ceylan
2015-02-20  7:30   ` Joe Perches
2015-02-20 19:47     ` Tolga Ceylan
2015-02-21  0:31       ` Tolga Ceylan
2015-02-21  1:59         ` Joe Perches
2015-03-07  0:57   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424411651-15978-3-git-send-email-tolga.ceylan@gmail.com \
    --to=tolga.ceylan@gmail.com \
    --cc=anarey@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.delve@gmail.com \
    --cc=rmfrfs@gmail.com \
    --cc=roxanagabriela10@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome