From: Philipp Zabel <p.zabel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: kernel@pengutronix.de, Pankaj Dubey <pankaj.dubey@samsung.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events
Date: Mon, 09 Mar 2015 10:48:22 +0100 [thread overview]
Message-ID: <1425894502.3152.12.camel@pengutronix.de> (raw)
In-Reply-To: <20150307105747.GC28806@sirena.org.uk>
Am Samstag, den 07.03.2015, 10:57 +0000 schrieb Mark Brown:
> On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:
>
> > #include <linux/sort.h>
> > -#include <trace/events/regmap.h>
> >
> > #include "internal.h"
> >
> > +#include <trace/events/regmap.h>
> > +
>
> The change is basically OK but the above is a bit too funky for my
> taste - it feels like it's asking for annoying compile breakage if
> anyone changes anything. I'd be more inclined to move the header
> somewhere where the events stuff can see it than do this.
Good point. As I see it I have three possiblities now:
a) Just #include "../../../drivers/base/regmap/internal.h" in
include/trace/events/regmap.h
b) Move drivers/base/regmap/internal.h to
include/linux/regmap-internal.h and
#include <linux/regmap-internal.h> in include/trace/events/regmap.h
c) Move include/trace/events/regmap.h to drivers/base/regmap/trace.h
and just #include "internal.h" in drivers/base/regmap/trace.h
Which, if any, of these options would you prefer? Here is an
unscientific survey:
a) $ git grep "#include \"\.\." include/
include/linux/libfdt.h:#include "../../scripts/dtc/libfdt/fdt.h"
include/linux/libfdt.h:#include "../../scripts/dtc/libfdt/libfdt.h"
include/xen/interface/io/vscsiif.h:#include "../grant_table.h"
b) $ find include/ -name "*internal.h"
include/linux/timekeeper_internal.h
c) $ find drivers/ -name trace.h
drivers/net/wireless/ath/ath10k/trace.h
drivers/net/wireless/ath/trace.h
drivers/net/wireless/ath/wil6210/trace.h
drivers/net/wireless/ath/ath5k/trace.h
drivers/net/wireless/ath/ath6kl/trace.h
drivers/usb/dwc3/trace.h
drivers/misc/cxl/trace.h
a) and b) aren't very common, and c) is mostly used by driver-level, not
subsystem-level trace events.
regards
Philipp
next prev parent reply other threads:[~2015-03-09 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 14:16 Philipp Zabel
2015-03-07 10:57 ` Mark Brown
2015-03-09 9:48 ` Philipp Zabel [this message]
2015-03-09 10:42 ` Mark Brown
2015-03-19 19:23 ` Steven Rostedt
2015-03-19 19:52 ` Steven Rostedt
2015-03-19 19:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425894502.3152.12.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®