From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Pankaj Dubey <pankaj.dubey@samsung.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events
Date: Sat, 7 Mar 2015 10:57:47 +0000 [thread overview]
Message-ID: <20150307105747.GC28806@sirena.org.uk> (raw)
In-Reply-To: <1425651415-31590-1-git-send-email-p.zabel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:
> #include <linux/sort.h>
> -#include <trace/events/regmap.h>
>
> #include "internal.h"
>
> +#include <trace/events/regmap.h>
> +
The change is basically OK but the above is a bit too funky for my
taste - it feels like it's asking for annoying compile breakage if
anyone changes anything. I'd be more inclined to move the header
somewhere where the events stuff can see it than do this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-07 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 14:16 Philipp Zabel
2015-03-07 10:57 ` Mark Brown [this message]
2015-03-09 9:48 ` Philipp Zabel
2015-03-09 10:42 ` Mark Brown
2015-03-19 19:23 ` Steven Rostedt
2015-03-19 19:52 ` Steven Rostedt
2015-03-19 19:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307105747.GC28806@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=p.zabel@pengutronix.de \
--cc=pankaj.dubey@samsung.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®