mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: mmarek@suse.cz, linux-kernel@vger.kernel.org,
	davej@codemonkey.org.uk, linux-api@vger.kernel.org
Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles
Date: Wed, 11 Mar 2015 10:36:07 +1100	[thread overview]
Message-ID: <1426030567.20917.3.camel@ellerman.id.au> (raw)
In-Reply-To: <54FE2377.9040709@osg.samsung.com>

On Mon, 2015-03-09 at 16:49 -0600, Shuah Khan wrote:
> On 03/09/2015 08:28 AM, Shuah Khan wrote:
> > On 03/04/2015 03:19 AM, Michael Ellerman wrote:
> >> The makefiles under tools/testing/selftests are not real kbuild
> >> makefiles, they are regular stand alone makefiles. As such they *do*
> >> want all the standard implicit rules and variables defined.
> >>
> >> So before calling those makefiles, filter -rR out of MAKEFLAGS.
> >>
> >> Without this not all the selftests are built correctly when called via
> >> the top-level Makefile.
> >>
> >> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > 
> > Hi Michal,
> > 
> > Could you please take this patch in your tree.
> > 
> > Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
> > 
> 
> I am changing this to a Nack. This is not fully cooked.
> I am seeing new failures on some tests.
> 
> gcc: error: elf_x86_64: No such file or directory
> gcc: error: unrecognized command line option ‘-m’

I can't reproduce that here. In what way do you think it's related to this
patch?

cheers




  reply	other threads:[~2015-03-10 23:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 10:19 Michael Ellerman
2015-03-09 14:28 ` Shuah Khan
2015-03-09 22:49   ` Shuah Khan
2015-03-10 23:36     ` Michael Ellerman [this message]
2015-03-10 23:39       ` Shuah Khan
2015-03-10 23:49         ` Michael Ellerman
2015-03-11  0:35           ` Shuah Khan
2015-03-11  0:46             ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426030567.20917.3.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome