From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
lm-sensors <lm-sensors@lm-sensors.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v4 2/5] documentation: update CodingStyle on local variables naming in macros
Date: Thu, 19 Mar 2015 18:27:42 +0100 [thread overview]
Message-ID: <1426786065-9798-3-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1426786065-9798-1-git-send-email-bgolaszewski@baylibre.com>
Describe proper naming convention for local variables in macros
resembling functions.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
Documentation/CodingStyle | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index 449a8a1..4d4f06d 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -659,6 +659,19 @@ macros using parameters.
#define CONSTANT 0x4000
#define CONSTEXP (CONSTANT | 3)
+5) namespace collisions when defining local variables in macros resembling
+functions:
+
+#define FOO(x) \
+({ \
+ typeof(x) ret; \
+ ret = calc_ret(x); \
+ (ret); \
+)}
+
+ret is a common name for a local variable - __foo_ret is less likely
+to collide with an existing variable.
+
The cpp manual deals with macros exhaustively. The gcc internals manual also
covers RTL which is used frequently with assembly language in the kernel.
--
2.1.4
next prev parent reply other threads:[~2015-03-19 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 17:27 [PATCH v4 0/5] new macro: find_closest() Bartosz Golaszewski
2015-03-19 17:27 ` [PATCH v4 1/5] util_macros.h: add find_closest() macro Bartosz Golaszewski
2015-03-20 20:49 ` Andrew Morton
2015-03-19 17:27 ` Bartosz Golaszewski [this message]
2015-03-19 23:22 ` [PATCH v4 2/5] documentation: update CodingStyle on local variables naming in macros Joe Perches
2015-03-19 17:27 ` [PATCH v4 3/5] hwmon: (ina2xx) replace ina226_avg_bits() with find_closest() Bartosz Golaszewski
2015-03-19 17:27 ` [PATCH v4 4/5] hwmon: (lm85) use find_closest() in x_TO_REG() functions Bartosz Golaszewski
2015-03-19 17:27 ` [PATCH v4 5/5] hwmon: (w83795) use find_closest_descending() in pwm_freq_to_reg() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426786065-9798-3-git-send-email-bgolaszewski@baylibre.com \
--to=bgolaszewski@baylibre.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome