From: Joe Perches <joe@perches.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
lm-sensors <lm-sensors@lm-sensors.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v4 2/5] documentation: update CodingStyle on local variables naming in macros
Date: Thu, 19 Mar 2015 16:22:35 -0700 [thread overview]
Message-ID: <1426807355.21142.21.camel@perches.com> (raw)
In-Reply-To: <1426786065-9798-3-git-send-email-bgolaszewski@baylibre.com>
On Thu, 2015-03-19 at 18:27 +0100, Bartosz Golaszewski wrote:
> Describe proper naming convention for local variables in macros
> resembling functions.
[]
> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
[]
> +5) namespace collisions when defining local variables in macros resembling
> +functions:
> +
> +#define FOO(x) \
> +({ \
> + typeof(x) ret; \
> + ret = calc_ret(x); \
> + (ret); \
trivia: ret wouldn't need parentheses here.
> +)}
> +
> +ret is a common name for a local variable - __foo_ret is less likely
> +to collide with an existing variable.
Is shadowing really much of a problem here?
These are statement expression macros and names
have local scope anyway.
It's similar to function arguments using the same
names as parameters.
next prev parent reply other threads:[~2015-03-19 23:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 17:27 [PATCH v4 0/5] new macro: find_closest() Bartosz Golaszewski
2015-03-19 17:27 ` [PATCH v4 1/5] util_macros.h: add find_closest() macro Bartosz Golaszewski
2015-03-20 20:49 ` Andrew Morton
2015-03-19 17:27 ` [PATCH v4 2/5] documentation: update CodingStyle on local variables naming in macros Bartosz Golaszewski
2015-03-19 23:22 ` Joe Perches [this message]
2015-03-19 17:27 ` [PATCH v4 3/5] hwmon: (ina2xx) replace ina226_avg_bits() with find_closest() Bartosz Golaszewski
2015-03-19 17:27 ` [PATCH v4 4/5] hwmon: (lm85) use find_closest() in x_TO_REG() functions Bartosz Golaszewski
2015-03-19 17:27 ` [PATCH v4 5/5] hwmon: (w83795) use find_closest_descending() in pwm_freq_to_reg() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426807355.21142.21.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bgolaszewski@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome