From: Martin Kepplinger <martink@posteo.de>
To: tomvanbraeckel@gmail.com
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, Martin Kepplinger <martink@posteo.de>
Subject: [PATCH 1/4] char: misc: document behaviour of open()
Date: Mon, 23 Mar 2015 13:59:46 +0100 [thread overview]
Message-ID: <1427115589-469-2-git-send-email-martink@posteo.de> (raw)
In-Reply-To: <1427115589-469-1-git-send-email-martink@posteo.de>
an open syscall now assignes file->private_data to a pointer to the
miscdevice structure. This reminds people not to duplicate code if
they want this and not to depend on it being NULL.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/char/misc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 32ab943..c05e2f4 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -168,7 +168,9 @@ static const struct file_operations misc_fops = {
* the minor number requested is used.
*
* The structure passed is linked into the kernel and may not be
- * destroyed until it has been unregistered.
+ * destroyed until it has been unregistered. By default, an open()
+ * syscall to the device sets file->private_data to point to the
+ * structure. Drivers don't need open in fops for this.
*
* A zero is returned on success and a negative errno code for
* failure.
--
2.1.4
next prev parent reply other threads:[~2015-03-23 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 21:08 [PATCH] Misc: pass miscdevice through file's private_data Tom Van Braeckel
2014-12-04 21:13 ` Greg KH
2014-12-04 23:01 ` Tom Van Braeckel
2014-12-04 23:29 ` Greg KH
2014-12-05 4:37 ` [PATCH] misc: " Tom Van Braeckel
2015-01-09 23:02 ` Greg KH
2015-01-11 15:44 ` Tom Van Braeckel
2015-03-23 12:59 ` always assign miscdevice to file->private_data Martin Kepplinger
2015-03-23 12:59 ` Martin Kepplinger [this message]
2015-03-23 12:59 ` [PATCH 2/4] fbdev: pxa3xx-gcu: remove redundant implementation of open() Martin Kepplinger
2015-03-23 12:59 ` [PATCH 3/4] fs: btrfs: set file->private data NULL after open() because we depend on it Martin Kepplinger
2015-03-23 12:59 ` [PATCH 4/4] lguest: explicitly set miscdevice's private_data NULL Martin Kepplinger
2015-03-31 13:08 ` [PATCH] misc: pass miscdevice through file's private_data Tom Van Braeckel
2015-03-31 13:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427115589-469-2-git-send-email-martink@posteo.de \
--to=martink@posteo.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomvanbraeckel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®