mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: tomvanbraeckel@gmail.com
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de
Subject: always assign miscdevice to file->private_data
Date: Mon, 23 Mar 2015 13:59:45 +0100	[thread overview]
Message-ID: <1427115589-469-1-git-send-email-martink@posteo.de> (raw)
In-Reply-To: <CAJ7vePD63YK3vfF40efV7CxKKJiRaeCY5tD4UsEOgn8MJY9ONw@mail.gmail.com>

I've been trying this a few months ago, ( https://lkml.org/lkml/2014/10/8/98 )
in a very bad attempt that (thankfully) failed.

I'm happy to see you trying this now and got the change in drivers/fuse
merged now. I've been running a kernel with this change for quite some time,
it's obviously fine.

I also only found the btrfs ioctl miscdevice as a main user that
has to change, and the lguest driver (I sent off the lguest patch to check
if this is correct.)

I append the additional changes I have applied locally (to the fuse change)
for you. Feel free to use, test, use my signed-off-by (if you have exactly
these changes) or send them off, however you want. Please be careful and
double check to have all necessary changes merged before doing the change
in misc_open().

Also, try to find drivers that assign or use struct miscdevice themselves.
Those can be simplified. And of course drivers that basically do nothing
in open(), just to have the link in private_data.

Thanks for the work!


  reply	other threads:[~2015-03-23 13:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 21:08 [PATCH] Misc: pass miscdevice through file's private_data Tom Van Braeckel
2014-12-04 21:13 ` Greg KH
2014-12-04 23:01   ` Tom Van Braeckel
2014-12-04 23:29     ` Greg KH
2014-12-05  4:37       ` [PATCH] misc: " Tom Van Braeckel
2015-01-09 23:02         ` Greg KH
2015-01-11 15:44           ` Tom Van Braeckel
2015-03-23 12:59             ` Martin Kepplinger [this message]
2015-03-23 12:59               ` [PATCH 1/4] char: misc: document behaviour of open() Martin Kepplinger
2015-03-23 12:59               ` [PATCH 2/4] fbdev: pxa3xx-gcu: remove redundant implementation " Martin Kepplinger
2015-03-23 12:59               ` [PATCH 3/4] fs: btrfs: set file->private data NULL after open() because we depend on it Martin Kepplinger
2015-03-23 12:59               ` [PATCH 4/4] lguest: explicitly set miscdevice's private_data NULL Martin Kepplinger
2015-03-31 13:08             ` [PATCH] misc: pass miscdevice through file's private_data Tom Van Braeckel
2015-03-31 13:19               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427115589-469-1-git-send-email-martink@posteo.de \
    --to=martink@posteo.de \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomvanbraeckel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®