From: Martin Kepplinger <martink@posteo.de>
To: tomvanbraeckel@gmail.com
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, Martin Kepplinger <martink@posteo.de>
Subject: [PATCH 3/4] fs: btrfs: set file->private data NULL after open() because we depend on it
Date: Mon, 23 Mar 2015 13:59:48 +0100 [thread overview]
Message-ID: <1427115589-469-4-git-send-email-martink@posteo.de> (raw)
In-Reply-To: <1427115589-469-1-git-send-email-martink@posteo.de>
We depend on private_data being NULL to record transaction ioctl start and end.
This allows the misc core's misc_open() to do whatever it wants.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
fs/btrfs/super.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 05fef19..00dd2a6 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1993,6 +1993,16 @@ static int btrfs_show_devname(struct seq_file *m, struct dentry *root)
return 0;
}
+static int btrfs_control_open(struct inode *inode, struct file *file)
+{
+ /*
+ * we use private_data in the transaction start ioctl to record
+ * it being started.
+ */
+ file->private_data = NULL;
+ return 0;
+}
+
static const struct super_operations btrfs_super_ops = {
.drop_inode = btrfs_drop_inode,
.evict_inode = btrfs_evict_inode,
@@ -2013,6 +2023,7 @@ static const struct file_operations btrfs_ctl_fops = {
.compat_ioctl = btrfs_control_ioctl,
.owner = THIS_MODULE,
.llseek = noop_llseek,
+ .open = btrfs_control_open,
};
static struct miscdevice btrfs_misc = {
--
2.1.4
next prev parent reply other threads:[~2015-03-23 13:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 21:08 [PATCH] Misc: pass miscdevice through file's private_data Tom Van Braeckel
2014-12-04 21:13 ` Greg KH
2014-12-04 23:01 ` Tom Van Braeckel
2014-12-04 23:29 ` Greg KH
2014-12-05 4:37 ` [PATCH] misc: " Tom Van Braeckel
2015-01-09 23:02 ` Greg KH
2015-01-11 15:44 ` Tom Van Braeckel
2015-03-23 12:59 ` always assign miscdevice to file->private_data Martin Kepplinger
2015-03-23 12:59 ` [PATCH 1/4] char: misc: document behaviour of open() Martin Kepplinger
2015-03-23 12:59 ` [PATCH 2/4] fbdev: pxa3xx-gcu: remove redundant implementation " Martin Kepplinger
2015-03-23 12:59 ` Martin Kepplinger [this message]
2015-03-23 12:59 ` [PATCH 4/4] lguest: explicitly set miscdevice's private_data NULL Martin Kepplinger
2015-03-31 13:08 ` [PATCH] misc: pass miscdevice through file's private_data Tom Van Braeckel
2015-03-31 13:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427115589-469-4-git-send-email-martink@posteo.de \
--to=martink@posteo.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomvanbraeckel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®