* [PATCH] bfs: correct return values
@ 2015-03-24 23:10 Sanidhya Kashyap
0 siblings, 0 replies; only message in thread
From: Sanidhya Kashyap @ 2015-03-24 23:10 UTC (permalink / raw)
To: tigran, linux-kernel
Cc: taesoo, changwoo, sanidhya, blee, csong84, Sanidhya Kashyap
In case of no memory allocation, the return should be
ENOMEM instead of ENOSPC. Well, for the other case, in which
the buffer head is not allocated, in that case -EIO should
be returned.
Signed-off-by: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
---
fs/bfs/dir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c
index 08063ae..7a818277 100644
--- a/fs/bfs/dir.c
+++ b/fs/bfs/dir.c
@@ -86,7 +86,7 @@ static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
inode = new_inode(s);
if (!inode)
- return -ENOSPC;
+ return -ENOMEM;
mutex_lock(&info->bfs_lock);
ino = find_first_zero_bit(info->si_imap, info->si_lasti + 1);
if (ino > info->si_lasti) {
@@ -293,7 +293,7 @@ static int bfs_add_entry(struct inode *dir, const unsigned char *name,
for (block = sblock; block <= eblock; block++) {
bh = sb_bread(dir->i_sb, block);
if (!bh)
- return -ENOSPC;
+ return -EIO;
for (off = 0; off < BFS_BSIZE; off += BFS_DIRENT_SIZE) {
de = (struct bfs_dirent *)(bh->b_data + off);
if (!de->ino) {
--
2.1.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-24 23:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-24 23:10 [PATCH] bfs: correct return values Sanidhya Kashyap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome