mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Roman Gushchin <klamm@yandex-team.ru>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: sysctl for RA default route MTU
Date: Wed, 25 Mar 2015 16:52:01 +0100	[thread overview]
Message-ID: <1427298721.2344863.245111901.25E46F85@webmail.messagingengine.com> (raw)
In-Reply-To: <1427281679-13007-1-git-send-email-klamm@yandex-team.ru>

On Wed, Mar 25, 2015, at 12:07, Roman Gushchin wrote:
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1714,6 +1714,14 @@ int ip6_route_add(struct fib6_config *cfg)
>  
>  	rt->rt6i_flags = cfg->fc_flags;
>  
> +       if ((cfg->fc_flags & (RTF_ADDRCONF | RTF_DEFAULT | RTF_GATEWAY))
> ==
> +           (RTF_ADDRCONF | RTF_DEFAULT | RTF_GATEWAY)) {
> +               u32 mtu = idev->cnf.ra_default_route_mtu;
> +
> +               if (mtu && mtu >= IPV6_MIN_MTU && mtu <= idev->cnf.mtu6)
> +                       dst_metric_set(&rt->dst, RTAX_MTU, mtu);
> +       }
> +

Could you move this RA specific snippet over to ndisc.c?

Hmm

How do you use this option?

You use jumbo frames on the on-link network and announce all routes via
route options where you also want to communicate to with jumbo frames?

I wonder if an offlink_mtu parameter would be more suitable?

Thanks,
Hannes

  parent reply	other threads:[~2015-03-25 15:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 18:03 [PATCH] " Roman Gushchin
2015-03-24 19:27 ` David Miller
2015-03-25  9:49   ` Roman Gushchin
2015-03-25 11:07   ` [PATCH v2] " Roman Gushchin
2015-03-25 12:34     ` Denis Kirjanov
2015-03-25 15:52     ` Hannes Frederic Sowa [this message]
     [not found]       ` <39171427301187@webcorp02f.yandex-team.ru>
2015-03-25 18:14         ` Hannes Frederic Sowa
2015-03-26 11:49           ` [PATCH v3] " Roman Gushchin
2015-03-26 14:49             ` Hannes Frederic Sowa
2015-03-29 19:42             ` David Miller
2015-03-30 12:30               ` Roman Gushchin
2015-03-31 20:05                 ` David Miller
2015-03-31 20:35                   ` Hannes Frederic Sowa
2015-03-31 20:49                     ` David Miller
2015-04-01  9:58                       ` Roman Gushchin
2015-04-01 17:55                         ` David Miller
2015-04-01 19:27                           ` Hannes Frederic Sowa
2015-04-02 18:08                             ` Roman Gushchin
2015-04-07 15:58                               ` Hannes Frederic Sowa
2015-04-08 19:03                                 ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427298721.2344863.245111901.25E46F85@webmail.messagingengine.com \
    --to=hannes@stressinduktion.org \
    --cc=davem@davemloft.net \
    --cc=klamm@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®