Re: [PATCH] firmware: dmi_scan: Prevent dmi_num integer overflow

[Jean Delvare <jdelvare@suse.de>]

Hi Matt,

Le Friday 27 March 2015 à 12:12 +0000, Matt Fleming a écrit :
> On Thu, 26 Mar, at 04:21:53PM, Jean Delvare wrote:
> > Le Thursday 26 March 2015 à 14:47 +0000, Matt Fleming a écrit :
> > > On Thu, 26 Mar, at 02:15:05PM, Jean Delvare wrote:
> > > > 
> > > > I don't actually have a tree, so feel free to pick it.
> > > 
> > > OK will do, but this is a regression fix for a potential bug introduced
> > > in commit 6d9ff4733172 ("firmware: dmi_scan: Fix dmi_len type"), right?
> > 
> > Not really. I'd rather say it complements commit 6d9ff4733172. The
> > actual bugs were introduced in commit fc43026278b2. But you can't really
> > call it a regression as SMBIOS 3.0 entry points were not supported at
> > all before that commit.
>  
> OK, thanks for clarifying.
> 
> > Still a reference to commit fc43026278b2 would certainly be appropriate,
> > as anyone backporting that commit will also want to pick the two
> > aforementioned fix-ups (plus ce204e9a4bd8 for that matter.)
> 
> commit ce204e9a4bd8 and 6d9ff4733172 are already tagged for stable, so
> we should be good there.
> 
> This is what I've got queued up to send to tip today. Feel free to send
> me another version today if you want to word things differently.

Looks good, thanks for taking care of it.

-- 
Jean Delvare
SUSE L3 Support