From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: David Cohen <david.a.cohen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Baolu Lu <baolu.lu@linux.intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [̈́PATCHv5 11/12] phy: helpers for USB ULPI PHY registering
Date: Wed, 13 May 2015 15:26:52 +0300 [thread overview]
Message-ID: <1431520013-78645-12-git-send-email-heikki.krogerus@linux.intel.com> (raw)
In-Reply-To: <1431520013-78645-1-git-send-email-heikki.krogerus@linux.intel.com>
ULPI PHYs need to be bound to their controllers with a
lookup. This adds helpers that the ULPI drivers can use to
do both, the registration of the PHY and the lookup, at the
same time.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 drivers/phy/ulpi_phy.h
diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h
new file mode 100644
index 0000000..ac49fb6
--- /dev/null
+++ b/drivers/phy/ulpi_phy.h
@@ -0,0 +1,31 @@
+#include <linux/phy/phy.h>
+
+/**
+ * Helper that registers PHY for a ULPI device and adds a lookup for binding it
+ * and it's controller, which is always the parent.
+ */
+static inline struct phy
+*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops)
+{
+ struct phy *phy;
+ int ret;
+
+ phy = phy_create(&ulpi->dev, NULL, ops);
+ if (IS_ERR(phy))
+ return phy;
+
+ ret = phy_create_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent));
+ if (ret) {
+ phy_destroy(phy);
+ return ERR_PTR(ret);
+ }
+
+ return phy;
+}
+
+/* Remove a PHY that was created with ulpi_phy_create() and it's lookup. */
+static inline void ulpi_phy_destroy(struct ulpi *ulpi, struct phy *phy)
+{
+ phy_remove_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent));
+ phy_destroy(phy);
+}
--
2.1.4
next prev parent reply other threads:[~2015-05-13 12:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 12:26 [̈́PATCHv5 00/12] usb: ulpi bus Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 01/12] usb: add bus type for USB ULPI Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 02/12] usb: dwc3: USB2 PHY register access bits Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 03/12] usb: dwc3: ULPI or UTMI+ select Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 04/12] usb: dwc3: store driver data earlier Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 05/12] usb: dwc3: cache hwparams earlier Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 06/12] usb: dwc3: soft reset to it's own function Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 07/12] usb: dwc3: setup phys earlier Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 08/12] usb: dwc3: add hsphy_interface property Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 09/12] usb: dwc3: pci: add quirk for Baytrails Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 10/12] usb: dwc3: add ULPI interface support Heikki Krogerus
2015-05-13 12:26 ` Heikki Krogerus [this message]
2015-05-13 12:26 ` [̈́PATCHv5 12/12] phy: add driver for TI TUSB1210 ULPI PHY Heikki Krogerus
2015-05-13 14:22 ` [̈́PATCHv5 00/12] usb: ulpi bus Al Viro
2015-05-15 7:09 ` Heikki Krogerus
2015-05-15 7:39 ` Tal Shorer
2015-05-15 10:31 ` Bjørn Mork
2015-05-15 12:03 ` Jeff Epler
2015-05-15 12:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431520013-78645-12-git-send-email-heikki.krogerus@linux.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=balbi@ti.com \
--cc=baolu.lu@linux.intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®