mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: David Cohen <david.a.cohen@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Baolu Lu <baolu.lu@linux.intel.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [̈́PATCHv5 07/12] usb: dwc3: setup phys earlier
Date: Wed, 13 May 2015 15:26:48 +0300	[thread overview]
Message-ID: <1431520013-78645-8-git-send-email-heikki.krogerus@linux.intel.com> (raw)
In-Reply-To: <1431520013-78645-1-git-send-email-heikki.krogerus@linux.intel.com>

This allows dwc3_phy_setup() to be more useful later. There
is nothing preventing the PHY configuration registers from
being programmed early. They do not loose their context in
soft reset.

There are however other PHY related operations that should
be executed before the driver request handles to the PHYs,
such as registering DWC3's ULPI interface, which can now be
done in dwc3_phy_setup().

Also, if there ever was need for the two 100ms delays in
dwc3_phy_setup() there isn't anymore. The PHYs are now reset
after the PHY interfaces are setup.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
---
 drivers/usb/dwc3/core.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 921f181..6b02e12 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -436,8 +436,6 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
 
 	dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(0), reg);
 
-	mdelay(100);
-
 	reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0));
 
 	/*
@@ -453,8 +451,6 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
 		reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
 
 	dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
-
-	mdelay(100);
 }
 
 /**
@@ -569,8 +565,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
 
 	dwc3_writel(dwc->regs, DWC3_GCTL, reg);
 
-	dwc3_phy_setup(dwc);
-
 	ret = dwc3_alloc_scratch_buffers(dwc);
 	if (ret)
 		goto err1;
@@ -892,6 +886,8 @@ static int dwc3_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, dwc);
 	dwc3_cache_hwparams(dwc);
 
+	dwc3_phy_setup(dwc);
+
 	ret = dwc3_core_get_phy(dwc);
 	if (ret)
 		goto err0;
-- 
2.1.4


  parent reply	other threads:[~2015-05-13 12:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 12:26 [̈́PATCHv5 00/12] usb: ulpi bus Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 01/12] usb: add bus type for USB ULPI Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 02/12] usb: dwc3: USB2 PHY register access bits Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 03/12] usb: dwc3: ULPI or UTMI+ select Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 04/12] usb: dwc3: store driver data earlier Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 05/12] usb: dwc3: cache hwparams earlier Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 06/12] usb: dwc3: soft reset to it's own function Heikki Krogerus
2015-05-13 12:26 ` Heikki Krogerus [this message]
2015-05-13 12:26 ` [̈́PATCHv5 08/12] usb: dwc3: add hsphy_interface property Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 09/12] usb: dwc3: pci: add quirk for Baytrails Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 10/12] usb: dwc3: add ULPI interface support Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 11/12] phy: helpers for USB ULPI PHY registering Heikki Krogerus
2015-05-13 12:26 ` [̈́PATCHv5 12/12] phy: add driver for TI TUSB1210 ULPI PHY Heikki Krogerus
2015-05-13 14:22 ` [̈́PATCHv5 00/12] usb: ulpi bus Al Viro
2015-05-15  7:09   ` Heikki Krogerus
2015-05-15  7:39     ` Tal Shorer
2015-05-15 10:31     ` Bjørn Mork
2015-05-15 12:03       ` Jeff Epler
2015-05-15 12:40       ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431520013-78645-8-git-send-email-heikki.krogerus@linux.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=david.a.cohen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®