mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	David Howells <dhowells@redhat.com>,
	Michal Marek <mmarek@suse.cz>,
	Abelardo Ricart III <aricart@memnix.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sedat Dilek <sedat.dilek@gmail.com>,
	keyrings@linux-nfs.org, Rusty Russell <rusty@rustcorp.com.au>,
	LSM List <linux-security-module@vger.kernel.org>,
	Borislav Petkov <bp@alien8.de>, Jiri Kosina <jkosina@suse.cz>
Subject: Re: Should we automatically generate a module signing key at all?
Date: Tue, 19 May 2015 21:25:05 +0100	[thread overview]
Message-ID: <1432067105.3277.95.camel@infradead.org> (raw)
In-Reply-To: <CALCETrVtuCAZQX=9FRo4FVfedAOWfj9mfYkadJPbKKB1rY-Z-A@mail.gmail.com>

On Tue, 2015-05-19 at 13:05 -0700, Andy Lutomirski wrote:
> > I appreciate why that's a problem in your scenario, but it's a valid and
> > useful feature of signatures, and I don't think we can just abandon it.
> 
> True, but I'd consider that use case (running a kernel built on a
> development machine) to be more in line with unsigned use or long-term
> (maybe medium-term) signing keys.
> 
> IOW, for this use case, running scripts/generate_module_signing_key or
> whatever and configuring accordingly seems entirely reasonable to me.
> Or you could just turn off forced module signature verification since
> keeping the signing key in plaintext on your machine mostly negates
> any benefit of verifying signatures on that machine at runtime.

Perhaps so (although it's ignoring use cases where the build tree is
somewhere secure and internal and I'm deploying to a server which is
more accessible).

But we already *fixed* the problem of generating the signing key
automatically. The in-tree signing_key.{priv,x509} are always transient
auto-generated files now, and the ambiguity is gone. As a side-effect of
what I was already doing to enable PKCS#11. It was mostly just a
documentation change.

So I'm not sure I see the point of ditching it, now that it's working.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


  reply	other threads:[~2015-05-19 20:25 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 16:04 David Howells
2015-05-18 16:19 ` David Woodhouse
2015-05-18 16:22   ` Linus Torvalds
2015-05-18 16:55     ` David Woodhouse
2015-05-18 16:20 ` Linus Torvalds
2015-05-19  0:51   ` Andy Lutomirski
2015-05-19  7:42     ` David Woodhouse
2015-05-19 17:44     ` Linus Torvalds
2015-05-19 17:58       ` Andy Lutomirski
2015-05-19 18:01         ` Linus Torvalds
2015-05-19 18:08         ` David Woodhouse
2015-05-19 18:12           ` Andy Lutomirski
2015-05-19 18:38             ` David Woodhouse
2015-05-19 18:49               ` Andy Lutomirski
2015-05-19 20:00                 ` David Woodhouse
2015-05-19 20:05                   ` Andy Lutomirski
2015-05-19 20:25                     ` David Woodhouse [this message]
2015-05-19 18:44           ` David Howells
2015-05-19 19:01             ` Andy Lutomirski
2015-05-21 16:10             ` David Howells
2015-05-21 16:50               ` Andy Lutomirski
2015-06-23 20:37       ` Pavel Machek
2015-05-20  5:01     ` Rusty Russell
2015-05-19  8:53   ` David Howells
2015-05-19 12:46     ` David Woodhouse
2015-05-19 12:52     ` David Howells
2015-05-19 14:36     ` Andy Lutomirski
2015-05-19 15:37       ` Mimi Zohar
2015-05-19 15:53         ` Petko Manolov
2015-05-19 17:17         ` Andy Lutomirski
2015-05-19 15:30     ` David Howells
2015-05-19 15:55       ` Theodore Ts'o
2015-05-19 16:09         ` Petko Manolov
2015-05-19 17:32         ` Mimi Zohar
2015-05-19 17:43           ` Andy Lutomirski
2015-05-19 17:53             ` Linus Torvalds
2015-05-19 16:23       ` David Howells
2015-05-19 17:55         ` Theodore Ts'o
2015-05-19 18:10         ` David Howells
2015-05-19 21:47         ` Jiri Kosina
2015-05-20  7:45           ` Michal Marek
2015-05-20  7:47         ` Michal Marek
2015-05-19 17:17       ` Andy Lutomirski
2015-05-19 18:38       ` David Howells
2015-05-19 18:46         ` Andy Lutomirski
2015-05-19 18:50         ` David Howells
2015-05-19 18:57         ` David Howells
2015-05-19 19:06           ` Andy Lutomirski
2015-05-21 15:59           ` David Howells
2015-05-21 23:54 George Spelvin
2015-05-22  0:03 ` Linus Torvalds
2015-05-22  0:10   ` Andy Lutomirski
2015-05-22 14:13   ` George Spelvin
2015-05-22 20:40     ` Linus Torvalds
2015-05-22 20:44       ` Andy Lutomirski
2015-05-22 21:09         ` Linus Torvalds
2015-05-22 22:18         ` David Howells
2015-05-22 22:21           ` Linus Torvalds
2015-05-22 22:15     ` David Howells
2015-05-22 22:19       ` Andy Lutomirski
2015-05-22 22:21       ` David Howells
2015-05-22  0:03 ` Andy Lutomirski
2015-05-22 12:42   ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432067105.3277.95.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=aricart@memnix.com \
    --cc=bp@alien8.de \
    --cc=dhowells@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=keyrings@linux-nfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rusty@rustcorp.com.au \
    --cc=sedat.dilek@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome