From: Rhyland Klein <rklein@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Alexandre Courbot <gnurou@gmail.com>,
Bill Huang <bilhuang@nvidia.com>, Jim Lin <jilin@nvidia.com>,
Benson Leung <bleung@chromium.org>, <linux-clk@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>,
Rhyland Klein <rklein@nvidia.com>
Subject: [PATCH v6 01/25] clk: tegra: Update struct tegra_clk_pll_params kerneldoc
Date: Thu, 18 Jun 2015 17:28:16 -0400 [thread overview]
Message-ID: <1434662920-21469-2-git-send-email-rklein@nvidia.com> (raw)
In-Reply-To: <1434662920-21469-1-git-send-email-rklein@nvidia.com>
From: Thierry Reding <treding@nvidia.com>
Benson Leung pointed out that the kerneldoc for this structure has
become stale. Update the field descriptions to match the structure
content.
Reported-by: Benson Leung <bleung@chromium.org>
Acked-by: Rhyland Klein <rklein@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Rhyland Klein <rklein@nvidia.com>
---
drivers/clk/tegra/clk.h | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h
index 29799e7f567a..bdc661cb81f0 100644
--- a/drivers/clk/tegra/clk.h
+++ b/drivers/clk/tegra/clk.h
@@ -157,7 +157,7 @@ struct div_nmp {
};
/**
- * struct clk_pll_params - PLL parameters
+ * struct tegra_clk_pll_params - PLL parameters
*
* @input_min: Minimum input frequency
* @input_max: Maximum input frequency
@@ -168,12 +168,24 @@ struct div_nmp {
* @base_reg: PLL base reg offset
* @misc_reg: PLL misc reg offset
* @lock_reg: PLL lock reg offset
- * @lock_bit_idx: Bit index for PLL lock status
+ * @lock_mask: Bitmask for PLL lock status
* @lock_enable_bit_idx: Bit index to enable PLL lock
+ * @iddq_reg: PLL IDDQ register offset
+ * @iddq_bit_idx: Bit index to enable PLL IDDQ
+ * @aux_reg: AUX register offset
+ * @dyn_ramp_reg: Dynamic ramp control register offset
+ * @ext_misc_reg: Miscellaneous control register offsets
+ * @pmc_divnm_reg: n, m divider PMC override register offset (PLLM)
+ * @pmc_divp_reg: p divider PMC override register offset (PLLM)
+ * @flags: PLL flags
+ * @stepa_shift: Dynamic ramp step A field shift
+ * @stepb_shift: Dynamic ramp step B field shift
* @lock_delay: Delay in us if PLL lock is not used
+ * @max_p: maximum value for the p divider
+ * @pdiv_tohw: mapping of p divider to register values
+ * @div_nmp: offsets and widths on n, m and p fields
* @freq_table: array of frequencies supported by PLL
* @fixed_rate: PLL rate if it is fixed
- * @flags: PLL flags
*
* Flags:
* TEGRA_PLL_USE_LOCK - This flag indicated to use lock bits for
--
1.7.9.5
next prev parent reply other threads:[~2015-06-18 21:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 21:28 [PATCH v6 00/25] Tegra210 Clock Support Rhyland Klein
2015-06-18 21:28 ` Rhyland Klein [this message]
2015-06-18 21:28 ` [PATCH v6 02/25] clk: tegra: Modify tegra_audio_clk_init to accept more plls Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 03/25] clk: tegra: periph: add new periph clks and muxes for Tegra210 Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 04/25] clk: tegra: pll: add tegra_pll_wait_for_lock to clk header Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 05/25] clk: tegra: pll: simplify clk_enable_path Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 06/25] clk: tegra: pll: update warning msg Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 07/25] clk: tegra: pll-params: change misc_reg count from 3 -> 6 Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 08/25] clk: tegra: pll: Don't unconditionally set LOCK flags Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 09/25] clk: tegra: pll: Add logic for handling SDM data Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 10/25] clk: tegra: pll: Add logic for out-of-table rates for T210 Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 11/25] clk: tegra: pll: Add code to handle if resets are supported by PLL Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 12/25] clk: tegra: Update PLLM handling Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 13/25] clk: tegra: pll: Add specialized logic for T210 Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 14/25] clk: tegra: pll: Add support for PLLMB " Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 15/25] clk: tegra: pll: Adjust vco_min if SDM present Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 16/25] clk: tegra: pll: Add Set_default logic Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 17/25] clk: tegra: pll: Add dyn_ramp callback Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 18/25] clk: tegra: pll: Add logic for SS Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 19/25] clk: tegra: pll: Fix _pll_ramp_calc_pll logic and _calc_dynamic_ramp_rate Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 20/25] clk: tegra: Add Super Gen5 Logic Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 21/25] clk: tegra210: add support for Tegra210 clocks Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 22/25] clk: tegra: pll: Fix issues with rates for VCO PLLs Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 23/25] clk: tegra: fix WARN_ON in PLL_RE registration Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 24/25] clk: tegra: read correct iddq register in PLL_SS registration Rhyland Klein
2015-06-18 21:28 ` [PATCH v6 25/25] clk: tegra: Add interface to enable hardware control of SATA/XUSB PLLs Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434662920-21469-2-git-send-email-rklein@nvidia.com \
--to=rklein@nvidia.com \
--cc=bilhuang@nvidia.com \
--cc=bleung@chromium.org \
--cc=gnurou@gmail.com \
--cc=jilin@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®