mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support
Date: Wed, 08 Jul 2015 22:39:56 +0200	[thread overview]
Message-ID: <1436387996.20619.54.camel@tiscali.nl> (raw)
In-Reply-To: <CAK7LNASnaN47cPHyyH-DTrF4pE4XqhgUdZLuOspuqHtKoDxmRQ@mail.gmail.com>

Hi Masahiro,

On wo, 2015-07-08 at 14:01 +0900, Masahiro Yamada wrote:
> Actually, most of pinctrl drivers are boolean, but most of them
> conventionally have MODULE_AUTHOR, THIS_MODULE, etc.
> 
> I do not think it looks so weird.  Thought?

It's a rather common pattern, but I think it's an anti-pattern
nevertheless. See the discussion that Shobhit Kumar, Paul Gortmaker, and
I had starting in https://lkml.org/lkml/2015/6/20/63 .

Please let me know if you're unconvinced by the arguments brought
forward by both Pauls in that discussion.

Thanks,


Paul Bolle

  reply	other threads:[~2015-07-08 20:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 12:29 [PATCH 0/7] This series adds pinctrl drivers for UniPhier SoC family Masahiro Yamada
2015-07-06 12:29 ` [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support Masahiro Yamada
2015-07-07  9:14   ` Paul Bolle
2015-07-08  5:01     ` Masahiro Yamada
2015-07-08 20:39       ` Paul Bolle [this message]
2015-07-09  5:32         ` Masahiro Yamada
2015-07-09  8:32           ` Paul Bolle
2015-07-06 12:29 ` [PATCH 2/7] pinctrl: UniPhier: add UniPhier PH1-LD4 pinctrl driver Masahiro Yamada
2015-07-06 12:29 ` [PATCH 3/7] pinctrl: UniPhier: add UniPhier PH1-Pro4 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 4/7] pinctrl: UniPhier: add UniPhier PH1-sLD8 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 5/7] pinctrl: UniPhier: add UniPhier PH1-Pro5 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 6/7] pinctrl: UniPhier: add UniPhier ProXstream2 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 7/7] pinctrl: UniPhier: add UniPhier PH1-LD6b " Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436387996.20619.54.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®