From: Paul Bolle <pebolle@tiscali.nl>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support
Date: Thu, 09 Jul 2015 10:32:46 +0200 [thread overview]
Message-ID: <1436430766.20619.91.camel@tiscali.nl> (raw)
In-Reply-To: <CAK7LNARqsxrFhSEOiZw7TYSyFR8vhaZYcK6KbuG84mP2eM5NJw@mail.gmail.com>
Hi Masahiro,
On do, 2015-07-09 at 14:32 +0900, Masahiro Yamada wrote:
> After I read your references and thought a bit more,
> I am now considering to change the bool into tristate.
>
> [...]
>
> Is this OK with you?
Whether this should be bool or tristate is up to you and the maintainer
(Linus?). I just prefer if you'd be consistent with that choice (ie, you
should not use module specific code in a built-in only driver).
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-07-09 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 12:29 [PATCH 0/7] This series adds pinctrl drivers for UniPhier SoC family Masahiro Yamada
2015-07-06 12:29 ` [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support Masahiro Yamada
2015-07-07 9:14 ` Paul Bolle
2015-07-08 5:01 ` Masahiro Yamada
2015-07-08 20:39 ` Paul Bolle
2015-07-09 5:32 ` Masahiro Yamada
2015-07-09 8:32 ` Paul Bolle [this message]
2015-07-06 12:29 ` [PATCH 2/7] pinctrl: UniPhier: add UniPhier PH1-LD4 pinctrl driver Masahiro Yamada
2015-07-06 12:29 ` [PATCH 3/7] pinctrl: UniPhier: add UniPhier PH1-Pro4 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 4/7] pinctrl: UniPhier: add UniPhier PH1-sLD8 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 5/7] pinctrl: UniPhier: add UniPhier PH1-Pro5 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 6/7] pinctrl: UniPhier: add UniPhier ProXstream2 " Masahiro Yamada
2015-07-06 12:29 ` [PATCH 7/7] pinctrl: UniPhier: add UniPhier PH1-LD6b " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436430766.20619.91.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®