From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
bobby.prani@gmail.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 09/16] cpu: Wait for RCU grace periods concurrently
Date: Fri, 17 Jul 2015 15:20:09 -0700 [thread overview]
Message-ID: <1437171616-13832-9-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1437171616-13832-1-git-send-email-paulmck@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
In kernels built with CONFIG_PREEMPT, _cpu_down() waits for RCU and
RCU-sched grace periods back-to-back, incurring quite a bit more latency
than required. This commit therefore uses the new synchronize_rcu_mult()
to allow waiting for both grace periods concurrently.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
kernel/cpu.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 9c9c9fab16cc..d63b062b6267 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -380,14 +380,14 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen)
* will observe it.
*
* For CONFIG_PREEMPT we have preemptible RCU and its sync_rcu() might
- * not imply sync_sched(), so explicitly call both.
+ * not imply sync_sched(), so wait for both.
*
* Do sync before park smpboot threads to take care the rcu boost case.
*/
-#ifdef CONFIG_PREEMPT
- synchronize_sched();
-#endif
- synchronize_rcu();
+ if (IS_ENABLED(CONFIG_PREEMPT))
+ synchronize_rcu_mult(call_rcu, call_rcu_sched);
+ else
+ synchronize_rcu();
smpboot_park_threads(cpu);
--
1.8.1.5
next prev parent reply other threads:[~2015-07-17 22:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 22:19 [PATCH tip/core/rcu 0/16] Miscellaneous fixes for 4.3 Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 01/16] rcu: Drop RCU_USER_QS in favor of NO_HZ_FULL Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 02/16] rcu: Deinline rcu_read_lock_sched_held() if DEBUG_LOCK_ALLOC Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 03/16] rcu: Change return type to bool Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 04/16] rcu: Add RCU-sched flavors of get-state and cond-sync Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 05/16] rcu: Hide RCU_NOCB_CPU behind RCU_EXPERT Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 06/16] rcu: Use WRITE_ONCE in RCU_INIT_POINTER Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 07/16] rcu: Fix obsolete priority-boosting comment Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 08/16] rcu: Create a synchronize_rcu_mult() Paul E. McKenney
2015-07-17 22:20 ` Paul E. McKenney [this message]
2015-07-17 22:20 ` [PATCH tip/core/rcu 10/16] rcu: Make rcu_is_watching() really notrace Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 11/16] rcu: Rename rcu_lockdep_assert() to RCU_LOCKDEP_WARN() Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 12/16] rcu: Fix backwards RCU_LOCKDEP_WARN() in synchronize_rcu_tasks() Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 13/16] rcu: Clarify CONFIG_RCU_EQS_DEBUG help text Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 14/16] rcu: update MAINTAINERS entry Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 15/16] scripts: Make checkpatch.pl warn on expedited RCU grace periods Paul E. McKenney
2015-07-17 22:37 ` Joe Perches
2015-07-21 0:41 ` Paul E. McKenney
2015-07-21 0:48 ` Joe Perches
2015-07-21 1:02 ` Paul E. McKenney
2015-07-21 0:55 ` Steven Rostedt
2015-07-21 1:06 ` Joe Perches
2015-07-21 1:15 ` Steven Rostedt
2015-07-21 17:18 ` Joe Perches
2015-07-21 20:11 ` Paul E. McKenney
2015-07-21 1:29 ` Paul E. McKenney
2015-07-21 1:58 ` Joe Perches
2015-07-21 3:24 ` Paul E. McKenney
2015-07-17 22:20 ` [PATCH tip/core/rcu 16/16] rcu: Don't disable CPU hotplug during OOM notifiers Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437171616-13832-9-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®