* [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing
@ 2015-07-21 8:41 Lukasz Anaczkowski
2015-07-21 20:11 ` Kristen Carlson Accardi
2015-07-23 21:01 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Lukasz Anaczkowski @ 2015-07-21 8:41 UTC (permalink / raw)
To: rjw, viresh.kumar
Cc: kristen, linux-pm, linux-kernel, yishimat, Lukasz Anaczkowski,
Dasaratharaman Chandramouli
Scaling for Knights Landing is same as the default scaling (100000).
When Knigts Landing support was added to the pstate driver, this
parameter was omitted resulting in a kernel panic during boot.
Reported-by: Yasuaki Ishimatsu <yishimat@redhat.com>
Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
---
drivers/cpufreq/intel_pstate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 15ada47..fcb929e 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -681,6 +681,7 @@ static struct cpu_defaults knl_params = {
.get_max = core_get_max_pstate,
.get_min = core_get_min_pstate,
.get_turbo = knl_get_turbo_pstate,
+ .get_scaling = core_get_scaling,
.set = core_set_pstate,
},
};
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing
2015-07-21 8:41 [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing Lukasz Anaczkowski
@ 2015-07-21 20:11 ` Kristen Carlson Accardi
2015-07-23 21:01 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Kristen Carlson Accardi @ 2015-07-21 20:11 UTC (permalink / raw)
To: Lukasz Anaczkowski
Cc: rjw, viresh.kumar, linux-pm, linux-kernel, yishimat,
Dasaratharaman Chandramouli
On Tue, 21 Jul 2015 10:41:13 +0200
Lukasz Anaczkowski <lukasz.anaczkowski@intel.com> wrote:
> Scaling for Knights Landing is same as the default scaling (100000).
> When Knigts Landing support was added to the pstate driver, this
> parameter was omitted resulting in a kernel panic during boot.
>
> Reported-by: Yasuaki Ishimatsu <yishimat@redhat.com>
> Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 15ada47..fcb929e 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -681,6 +681,7 @@ static struct cpu_defaults knl_params = {
> .get_max = core_get_max_pstate,
> .get_min = core_get_min_pstate,
> .get_turbo = knl_get_turbo_pstate,
> + .get_scaling = core_get_scaling,
> .set = core_set_pstate,
> },
> };
Acked-by: Kristen Carlson Accardi <kristen@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing
2015-07-21 8:41 [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing Lukasz Anaczkowski
2015-07-21 20:11 ` Kristen Carlson Accardi
@ 2015-07-23 21:01 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-07-23 21:01 UTC (permalink / raw)
To: Lukasz Anaczkowski
Cc: viresh.kumar, kristen, linux-pm, linux-kernel, yishimat,
Dasaratharaman Chandramouli
On Tuesday, July 21, 2015 10:41:13 AM Lukasz Anaczkowski wrote:
> Scaling for Knights Landing is same as the default scaling (100000).
> When Knigts Landing support was added to the pstate driver, this
> parameter was omitted resulting in a kernel panic during boot.
>
> Reported-by: Yasuaki Ishimatsu <yishimat@redhat.com>
> Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
Queued up for 4.3, thanks!
> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 15ada47..fcb929e 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -681,6 +681,7 @@ static struct cpu_defaults knl_params = {
> .get_max = core_get_max_pstate,
> .get_min = core_get_min_pstate,
> .get_turbo = knl_get_turbo_pstate,
> + .get_scaling = core_get_scaling,
> .set = core_set_pstate,
> },
> };
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-23 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-21 8:41 [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing Lukasz Anaczkowski
2015-07-21 20:11 ` Kristen Carlson Accardi
2015-07-23 21:01 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®