mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mhocko@kernel.org
To: "David S. Miller" <davem@davemloft.net>
Cc: Mel Gorman <mgorman@suse.de>, Eric Dumazet <edumazet@google.com>,
	linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: [PATCH] net, skbuff: Get rid of unused skb_propagate_pfmemalloc
Date: Thu, 27 Aug 2015 10:46:37 +0200	[thread overview]
Message-ID: <1440665197-23079-1-git-send-email-mhocko@kernel.org> (raw)

From: Michal Hocko <mhocko@suse.com>

It seems that skb_propagate_pfmemalloc has never had a user since it was
introduced by 0614002bb5f7 ("netvm: propagate page->pfmemalloc from
skb_alloc_page to skb"). Remove it.

Signed-off-by: Michal Hocko <mhocko@suse.com>
---
Hi,
this has been noticed while working on 2f064f3485cd ("mm: make page
pfmemalloc check more robust").

 include/linux/skbuff.h | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 9b88536487e6..9fcf69daa26c 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2252,18 +2252,6 @@ static inline struct page *dev_alloc_page(void)
 }
 
 /**
- *	skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page
- *	@page: The page that was allocated from skb_alloc_page
- *	@skb: The skb that may need pfmemalloc set
- */
-static inline void skb_propagate_pfmemalloc(struct page *page,
-					     struct sk_buff *skb)
-{
-	if (page_is_pfmemalloc(page))
-		skb->pfmemalloc = true;
-}
-
-/**
  * skb_frag_page - retrieve the page referred to by a paged fragment
  * @frag: the paged fragment
  *
-- 
2.5.0


             reply	other threads:[~2015-08-27  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  8:46 mhocko [this message]
2015-09-25 14:11 ` Michal Hocko
2016-10-19 12:32 Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440665197-23079-1-git-send-email-mhocko@kernel.org \
    --to=mhocko@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome