From: Michal Hocko <mhocko@kernel.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: [PATCH] net, skbuff: Get rid of unused skb_propagate_pfmemalloc
Date: Wed, 19 Oct 2016 14:32:22 +0200 [thread overview]
Message-ID: <20161019123222.17404-1-mhocko@kernel.org> (raw)
From: Michal Hocko <mhocko@suse.com>
It seems that skb_propagate_pfmemalloc has never had a user since it was
introduced by 0614002bb5f7 ("netvm: propagate page->pfmemalloc from
skb_alloc_page to skb"). Remove it.
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
Hi,
I've posted this trivial cleanup quite some time ago but it seemed to
fall through cracks. I've found it again while cleaning up my local repo.
Is there any interest in it or should I just drop it and do not care?
include/linux/skbuff.h | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 601258f6e621..641843a786d8 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2535,18 +2535,6 @@ static inline struct page *dev_alloc_page(void)
}
/**
- * skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page
- * @page: The page that was allocated from skb_alloc_page
- * @skb: The skb that may need pfmemalloc set
- */
-static inline void skb_propagate_pfmemalloc(struct page *page,
- struct sk_buff *skb)
-{
- if (page_is_pfmemalloc(page))
- skb->pfmemalloc = true;
-}
-
-/**
* skb_frag_page - retrieve the page referred to by a paged fragment
* @frag: the paged fragment
*
--
2.9.3
next reply other threads:[~2016-10-19 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 12:32 Michal Hocko [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-27 8:46 mhocko
2015-09-25 14:11 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019123222.17404-1-mhocko@kernel.org \
--to=mhocko@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome