Re: [PATCH] net, skbuff: Get rid of unused skb_propagate_pfmemalloc

[Michal Hocko <mhocko@kernel.org>]

On Thu 27-08-15 10:46:37, mhocko@kernel.org wrote:
> From: Michal Hocko <mhocko@suse.com>
> 
> It seems that skb_propagate_pfmemalloc has never had a user since it was
> introduced by 0614002bb5f7 ("netvm: propagate page->pfmemalloc from
> skb_alloc_page to skb"). Remove it.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
> Hi,
> this has been noticed while working on 2f064f3485cd ("mm: make page
> pfmemalloc check more robust").

Has this just fallen through cracks or it is not interesting?

> 
>  include/linux/skbuff.h | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 9b88536487e6..9fcf69daa26c 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -2252,18 +2252,6 @@ static inline struct page *dev_alloc_page(void)
>  }
>  
>  /**
> - *	skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page
> - *	@page: The page that was allocated from skb_alloc_page
> - *	@skb: The skb that may need pfmemalloc set
> - */
> -static inline void skb_propagate_pfmemalloc(struct page *page,
> -					     struct sk_buff *skb)
> -{
> -	if (page_is_pfmemalloc(page))
> -		skb->pfmemalloc = true;
> -}
> -
> -/**
>   * skb_frag_page - retrieve the page referred to by a paged fragment
>   * @frag: the paged fragment
>   *
> -- 
> 2.5.0
> 

-- 
Michal Hocko
SUSE Labs