* [PATCH] reset: Add (devm_)reset_control_get stub functions
@ 2015-08-31 9:22 Axel Lin
2015-08-31 14:56 ` Mark Brown
2015-08-31 16:01 ` Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-08-31 9:22 UTC (permalink / raw)
To: Philipp Zabel
Cc: Mark Brown, Takashi Iwai, Arnaud Pouliquen, Liam Girdwood,
alsa-devel, linux-kernel
So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
include/linux/reset.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index da5602b..cd42c1b 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -74,6 +74,18 @@ static inline int device_reset_optional(struct device *dev)
return -ENOSYS;
}
+static inline struct reset_control *reset_control_get(
+ struct device *dev, const char *id)
+{
+ return ERR_PTR(-ENOSYS);
+}
+
+static inline struct reset_control *devm_reset_control_get(
+ struct device *dev, const char *id)
+{
+ return ERR_PTR(-ENOSYS);
+}
+
static inline struct reset_control *reset_control_get_optional(
struct device *dev, const char *id)
{
--
2.1.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] reset: Add (devm_)reset_control_get stub functions
2015-08-31 9:22 [PATCH] reset: Add (devm_)reset_control_get stub functions Axel Lin
@ 2015-08-31 14:56 ` Mark Brown
2015-08-31 16:01 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-08-31 14:56 UTC (permalink / raw)
To: Axel Lin
Cc: Philipp Zabel, Takashi Iwai, Arnaud Pouliquen, Liam Girdwood,
alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
On Mon, Aug 31, 2015 at 05:22:23PM +0800, Axel Lin wrote:
> So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
The lack of this is breaking the build for the newly added ASoC STI
driver in some COMPILE_TEST configurations, can we please get this in
for v4.3-rc1?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] reset: Add (devm_)reset_control_get stub functions
2015-08-31 9:22 [PATCH] reset: Add (devm_)reset_control_get stub functions Axel Lin
2015-08-31 14:56 ` Mark Brown
@ 2015-08-31 16:01 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2015-08-31 16:01 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Takashi Iwai, Arnaud Pouliquen, Liam Girdwood,
alsa-devel, linux-kernel
Hi Axel,
thank you for the patch.
Am Montag, den 31.08.2015, 17:22 +0800 schrieb Axel Lin:
> So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> include/linux/reset.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index da5602b..cd42c1b 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -74,6 +74,18 @@ static inline int device_reset_optional(struct device *dev)
> return -ENOSYS;
> }
>
> +static inline struct reset_control *reset_control_get(
> + struct device *dev, const char *id)
> +{
> + return ERR_PTR(-ENOSYS);
> +}
> +
> +static inline struct reset_control *devm_reset_control_get(
> + struct device *dev, const char *id)
> +{
> + return ERR_PTR(-ENOSYS);
> +}
> +
Could you add a WARN_ON(1) to both, make them __must_check, and return
something other than -ENOSYS. For example the gpio stubs return -EINVAL.
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-31 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-31 9:22 [PATCH] reset: Add (devm_)reset_control_get stub functions Axel Lin
2015-08-31 14:56 ` Mark Brown
2015-08-31 16:01 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome