mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Ohad Ben-Cohen <ohad@wizery.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: <linux-kernel@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	Suman Anna <s-anna@ti.com>
Subject: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers
Date: Wed, 16 Sep 2015 19:29:17 -0500	[thread overview]
Message-ID: <1442449758-14594-2-git-send-email-s-anna@ti.com> (raw)
In-Reply-To: <1442449758-14594-1-git-send-email-s-anna@ti.com>

The virtio core uses a static ida named virtio_index_ida for
assigning index numbers to virtio devices during registration.
The ida core may allocate some internal idr cache layers and
an ida bitmap upon any ida allocation, and all these layers are
truely freed only upon the ida destruction. The virtio_index_ida
is not destroyed at present, leading to a memory leak when using
the virtio core as a module and atleast one virtio device is
registered and unregistered.

Fix this by invoking ida_destroy() in the virtio core module
exit.

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/virtio/virtio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index b1877d73fa56..7062bb0975a5 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -412,6 +412,7 @@ static int virtio_init(void)
 static void __exit virtio_exit(void)
 {
 	bus_unregister(&virtio_bus);
+	ida_destroy(&virtio_index_ida);
 }
 core_initcall(virtio_init);
 module_exit(virtio_exit);
-- 
2.5.0


  reply	other threads:[~2015-09-17  0:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  0:29 [PATCH 0/2] Fix memory leaks in virtio & remoteproc cores Suman Anna
2015-09-17  0:29 ` Suman Anna [this message]
2015-09-17  5:33   ` DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers) Michael S. Tsirkin
2015-09-17  6:51     ` Hannes Reinecke
2015-09-17 22:32       ` Suman Anna
2015-09-17 14:15     ` James Bottomley
2015-09-17 15:10       ` Tejun Heo
2015-09-17 16:06       ` Michael S. Tsirkin
2015-09-17 16:48         ` James Bottomley
2015-09-17 17:15           ` Tejun Heo
2015-09-17 17:58             ` James Bottomley
2015-09-17 18:00               ` Tejun Heo
2015-09-17  0:29 ` [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Suman Anna
2015-11-26  9:38   ` Ohad Ben-Cohen
2015-11-26 10:37     ` Michael S. Tsirkin
2015-11-26 15:47       ` Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442449758-14594-2-git-send-email-s-anna@ti.com \
    --to=s-anna@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=ohad@wizery.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®