From: Suman Anna <s-anna@ti.com>
To: Ohad Ben-Cohen <ohad@wizery.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: <linux-kernel@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
Suman Anna <s-anna@ti.com>
Subject: [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers
Date: Wed, 16 Sep 2015 19:29:18 -0500 [thread overview]
Message-ID: <1442449758-14594-3-git-send-email-s-anna@ti.com> (raw)
In-Reply-To: <1442449758-14594-1-git-send-email-s-anna@ti.com>
The remoteproc core uses a static ida named rproc_dev_index for
assigning an automatic index number to a registered remoteproc.
The ida core may allocate some internal idr cache layers and ida
bitmap upon any ida allocation, and all these layers are truely
freed only upon the ida destruction. The rproc_dev_index ida is
not destroyed at present, leading to a memory leak when using the
remoteproc core as a module and atleast one rproc device is
registered and unregistered.
Fix this by invoking ida_destroy() in the remoteproc core module
exit.
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
---
drivers/remoteproc/remoteproc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 8b3130f22b42..9e03d158f411 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1478,6 +1478,8 @@ module_init(remoteproc_init);
static void __exit remoteproc_exit(void)
{
+ ida_destroy(&rproc_dev_index);
+
rproc_exit_debugfs();
}
module_exit(remoteproc_exit);
--
2.5.0
next prev parent reply other threads:[~2015-09-17 0:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 0:29 [PATCH 0/2] Fix memory leaks in virtio & remoteproc cores Suman Anna
2015-09-17 0:29 ` [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers Suman Anna
2015-09-17 5:33 ` DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers) Michael S. Tsirkin
2015-09-17 6:51 ` Hannes Reinecke
2015-09-17 22:32 ` Suman Anna
2015-09-17 14:15 ` James Bottomley
2015-09-17 15:10 ` Tejun Heo
2015-09-17 16:06 ` Michael S. Tsirkin
2015-09-17 16:48 ` James Bottomley
2015-09-17 17:15 ` Tejun Heo
2015-09-17 17:58 ` James Bottomley
2015-09-17 18:00 ` Tejun Heo
2015-09-17 0:29 ` Suman Anna [this message]
2015-11-26 9:38 ` [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Ohad Ben-Cohen
2015-11-26 10:37 ` Michael S. Tsirkin
2015-11-26 15:47 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442449758-14594-3-git-send-email-s-anna@ti.com \
--to=s-anna@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®