mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Suman Anna <s-anna@ti.com>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com
Subject: Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)
Date: Thu, 17 Sep 2015 13:15:29 -0400	[thread overview]
Message-ID: <20150917171529.GA15447@htj.duckdns.org> (raw)
In-Reply-To: <1442508517.4073.13.camel@HansenPartnership.com>

Hello,

On Thu, Sep 17, 2015 at 09:48:37AM -0700, James Bottomley wrote:
> Well, there's an easy fix for that.  We could have ida_remove() actually
> free the bitmap and not cache it if it's the last layer.  That way ida
> would naturally empty and we wouldn't need a destructor.   Tejun, would
> that work?

Yeah, that definitely is one way to go about it.  It kinda muddles the
purpose of ida_destroy() tho.  I suppose we can rename it to
idr_remove_all() and then do the same to idr.  I'm not particularly
objecting to all that but what's wrong with just calling idr_destroy()
on exit paths?  If missing the call in modules is an issue, maybe we
can just annotate idr/ida with debugobj?

Thanks.

-- 
tejun

  reply	other threads:[~2015-09-17 17:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  0:29 [PATCH 0/2] Fix memory leaks in virtio & remoteproc cores Suman Anna
2015-09-17  0:29 ` [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers Suman Anna
2015-09-17  5:33   ` DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers) Michael S. Tsirkin
2015-09-17  6:51     ` Hannes Reinecke
2015-09-17 22:32       ` Suman Anna
2015-09-17 14:15     ` James Bottomley
2015-09-17 15:10       ` Tejun Heo
2015-09-17 16:06       ` Michael S. Tsirkin
2015-09-17 16:48         ` James Bottomley
2015-09-17 17:15           ` Tejun Heo [this message]
2015-09-17 17:58             ` James Bottomley
2015-09-17 18:00               ` Tejun Heo
2015-09-17  0:29 ` [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Suman Anna
2015-11-26  9:38   ` Ohad Ben-Cohen
2015-11-26 10:37     ` Michael S. Tsirkin
2015-11-26 15:47       ` Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917171529.GA15447@htj.duckdns.org \
    --to=htejun@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=ohad@wizery.com \
    --cc=open-iscsi@googlegroups.com \
    --cc=s-anna@ti.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®