* [PATCH 1/1] fs/seq_file: use seq_* helpers in seq_hex_dump()
@ 2015-09-18 8:51 Andy Shevchenko
0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2015-09-18 8:51 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, Alexander Viro; +Cc: Andy Shevchenko
This improves code readability.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
fs/seq_file.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index 6f0c3d7..ade4ea2 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -752,6 +752,8 @@ void seq_hex_dump(struct seq_file *m, const char *prefix_str, int prefix_type,
{
const u8 *ptr = buf;
int i, linelen, remaining = len;
+ char *buffer;
+ size_t size;
int ret;
if (rowsize != 16 && rowsize != 32)
@@ -773,15 +775,12 @@ void seq_hex_dump(struct seq_file *m, const char *prefix_str, int prefix_type,
break;
}
+ size = seq_get_buf(m, &buffer);
ret = hex_dump_to_buffer(ptr + i, linelen, rowsize, groupsize,
- m->buf + m->count, m->size - m->count,
- ascii);
- if (ret >= m->size - m->count) {
- seq_set_overflow(m);
- } else {
- m->count += ret;
- seq_putc(m, '\n');
- }
+ buffer, size, ascii);
+ seq_commit(m, ret < size ? ret : -1);
+
+ seq_putc(m, '\n');
}
}
EXPORT_SYMBOL(seq_hex_dump);
--
2.5.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-18 8:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-18 8:51 [PATCH 1/1] fs/seq_file: use seq_* helpers in seq_hex_dump() Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®